mclear-tools / build-emacs-macos Goto Github PK

I found the related code in emacs 30 has been changed, thus this patch should be no longer needed?

The script uses the trash command.

I was not familiar with that command, but a quick search seems to suggest it should be added to the bemacs-requirements.sh file.

First, thank you for writing this script - it's the only way I've been able to get nativecomp to work on my M1 pro.

Problem: The build script fails on the latest 'known good' nightly build of emacs, 48cb9c4aaadfe7bd50c13f658a6e8e9e97587867 . I will edit this issue later with the exact error message, but it's to do with libxml2. I can confirm that the issue is caused by emacs itself, as building the previous known good nightly, 8c8093aa6f20a7a4f3799cbdb9270cac013ef71d , works fine. I know I should expect errors when doing nightly builds, just thought you should know in case some change in emacs is going to break this script in the future.

Steps to reproduce: Call the provided script and pass it 48cb9c4aaadfe7bd50c13f658a6e8e9e97587867.

Things tried: brew reinstalling all dependencies.

Potential cause: Something that was changed between the two versions: emacs-mirror/emacs@8c8093a...48cb9c4aaadfe7bd50c13f658a6e8e9e97587867/ . I'm going to try to narrow this down by attempting builds on intermediate commits later.