Don't be so strict on id comparison in getNodeById about jqtree HOT 10 CLOSED

Yes, I think that getNodeById should compare the ids 'unstrict'. Converting the ids to strings is probably a good way to do this.

from jqtree.

I've thought in a better way. There is another issue I guess with the way getNodeByXXX is currently implemented. jqTree should keep they indexed by an object/hash. That way, not only it should perform better but CoffeeScript wouldn't do any strict comparison if you're accessing the hash by id.

For example: @nodeById[id] and @nodeByName[id] would translate to this.nodeByXXX[xxx] and then no strict comparison would be performed.

And it would also perform much better than iterating over the entire tree. What do you think?

from jqtree.

In which situation do you use the function getNodeById? Are there any performance issues?

from jqtree.

Actually, I'm not using getNodeById anymore since yesterday and just using my internal map. This is more of a design decision than one based on performance. But here is the typical usage for getting the node from an id:

You have a button set in a <div data-id=2>buttons here</div>. Then you have a live event handler on those buttons and you get the id from their parent's div. Then you'll issue some AJAX request. Usually in my request's response I have access to the id of the created/updated new element so that I don't even need to store the id from the button's parent div.

Finally I need to do some operation where I need the id. For example, if it is a create action I'll need to append some node and I'll need a node as returned by getNodeById for that. But actually I've added the node information to my internal fields hash on onCreateLi handler.

from jqtree.

I can see the use for a fast getNodeById function. Do you also use getNodeByName? I only use it in the unit tests myself.

from jqtree.

Never used it.

from jqtree.

The getNodeById comparison is now less strict. It uses the javascript '=='.

I'm working on a performance improvement getNodeById that uses an index.

from jqtree.

Great, thanks :)

from jqtree.

Performance improvement is implemented in version 0.10

from jqtree.

Thanks, @mbraak :)

from jqtree.