Inconsistent/incorrect drag & drop node highlighting about jqtree HOT 9 CLOSED

This is the pr with the possible fix: #752

from jqtree.

I can reproduce the error. Sorry about this, apparently the original fix was reverted by a refactoring of the dnd code.
I'm fixing it again in #795.

from jqtree.

This is fixed in version 1.8.2.

from jqtree.

I'll have a look

from jqtree.

Thanks Marco, from my testing this seems to have resolved all of the above issues. Top marks! Many thanks.

from jqtree.

The fix is included in release 1.7.4

from jqtree.

Hi there, all of the above issues are now back, haven't checked which version this occurred. In addition, using "Example 3 - Drag and drop" as before from the github site:

Test 6:

• Drag Theropods (closed with children) onto Herrerasaurians, adding it as a child.
• With Theropods still closed, drag to the right, insert points above and below appear correctly. Leave Theropods where it is.
• Open Theropods, drag to the right, the initial insert point appears above Saurischia, this has 2 issues, the insert point shouldn't appear at all when just dragging to the right still over the source node, secondly the first insert point is one level before above Herrerasaurians.
• Before moving down the insert point moves to above Herrerasaurians
• Keep moving down, the insert point appears above Sauropodomorphs when the drag is still some 2/3 nodes above (over Spinosauroids)
• It is now impossible (unless one drags out of the tree) to drop Theropods back onto itself for a no-move drop as wherever one moves an insert highlight appears above or below.

The above is probably just a variation of Tests 4 & 5. What I've noticed is that with the tree nodes closed the insert points seem to work fine, the problem is when the node is opened with children below.

from jqtree.

I'll have a look.

from jqtree.

Thanks Marco, this has fixed the above test cases. Once again thanks for your diligence and continued effort with this project.

from jqtree.