Just clone the repo and then ran the build

(!) Circular dependency
src/components/BookmarkNode.ts -> src/components/BookmarkFolder.svelte -> src/components/BookmarkNode.ts

How to download currently latest build v0.14.0 for chrome?
On webstore it's old version.

I have tons of bookmarks, Unable to access all of them.

Once PR #273 is merged, there is an issue with the menu icon overlapping the search input because the menu icon is now position: fixed.

is it blazingly fast?

The next public release is currently blocked due to:

• Bookmark folder popups render off screen when too far to the right: #1121
• Bookmark folder popups don't show and hide at the correct time: #1122
• Bookmark folders don't look correct: #1120, #1123
• Settings UI needs updating, doesn't need to be perfect but at least a basic refresh: #621
• Chrome Web Store listing needs updating: #1119, #259

I want to get all of these fixed before publishing the next public release. For anyone who wants to try intermittent versions you can go to https://github.com/maxmilton/new-tab/releases and manually install the latest release's chrome-extension.zip.

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Awaiting Schedule

These updates are awaiting their schedule. Click on a checkbox to get an update now.

• chore(deps): lock file maintenance

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update dependency @types/chrome to v0.0.267
• chore(deps): update dependency prettier to v3.2.5
• chore(deps): update dependency @playwright/test to v1.43.1
• chore(deps): update dependency @types/bun to v1.1.1
• chore(deps): update dependency bun-types to v1.1.7
• chore(deps): update dependency eslint to v8.57.0
• chore(deps): update dependency happy-dom to v13.10.1
• chore(deps): update dependency lightningcss to v1.24.1
• chore(deps): update dependency stylelint to v16.5.0
• chore(deps): update dependency terser to v5.31.0
• chore(deps): update dependency typescript to v5.4.5
• chore(deps): update typescript-eslint monorepo to v6.21.0 (@typescript-eslint/eslint-plugin, @typescript-eslint/parser)
• chore(deps): update dependency eslint to v9
• chore(deps): update dependency eslint-config-airbnb-typescript to v18
• chore(deps): update dependency eslint-plugin-unicorn to v52
• chore(deps): update dependency happy-dom to v14
• chore(deps): update typescript-eslint monorepo to v7 (major) (@typescript-eslint/eslint-plugin, @typescript-eslint/parser)
• Click on this checkbox to rebase all open PRs at once

Ignored or Blocked

These are blocked by an existing closed PR and will not be recreated unless you click a checkbox below.

• fix(deps): update dependency stage1 to v0.8.0-next.8

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

After the fixes for #1122 we are in a position where bookmark popups are shown/dismissed at the right time, other than the scenario where a folder popup is open and when mousing over to it the mouse cursor hits another folder opening it + dismissing the actual target folder. This leads to opening the wrong folder too easily.

We could fix this by adding a short delay before opening folder popups. Getting the timing just right might be interesting... 160ms?

When a bookmark folder is empty it should be clear to the user. Chrome shows a (empty) item in the folder popup in a muted colour. We should do the same.

On the old master release branch this was already implemented but after the big refactor it now needs to be implemented again.

When a folder popup is rendered we need to check if its position fits on the screen (horizontally) and if not then handle appropriately.

If the level is 1 (bookmarks bar is level 0) then probably render the right edge aligned with the right side of the screen (CSS right: 0). If the level is > 1 experiment with rendering the folder popup to the left of the parent folder (including for nested levels too for consistency).

Another issue arising from PR #273, in order to get the best possible performance, favicons are loaded directly from the Chrome favicon cache (chrome://favicon/). This is amazing for performance because there's no remote network requests slowing down page rendering.

The issue arises in that when you open a website for the first time and its favicon is not in the cache, it will never change from the default favicon, even after the chrome.tabs.onUpdated event. Apparently it can take a moment for the favicon to be added to the cache but its well after the tab update event has fired.

There are some existing Chrome bugs which could be related to this but we might still be able to implement a workaround using a combination of chrome://favicon/ and changeInfo.favIconUrl in the meantime.

Related:

• https://bugs.chromium.org/p/chromium/issues/detail?id=690138
• https://developer.chrome.com/extensions/tabs

On the next branch the logic behind rendering bookmark subfolders has been rewritten.

Before it was CSS based for layout etc. which was great for performance and simplifying logic but had limitations like the inability to scroll a long list of bookmark items or control folder position when overflowing the screen. The new logic is JS based so there's no longer any issues with position and layout, however, the implementation is still incomplete.

Current issues:

• There should be a short delay before opening the first folder on hover to prevent accidental opens (this works now!).
  • After the first folder is open, there should be no delay opening nested folders since that's annoying and feels like the app has frozen (Chrome actually still uses a delay for nested folders but I don't think that's ideal).
• There should also be a delay before closing a folder popup (on mouseout) to closing when the user is moving their mouse to a nested folder etc. (this work now too! Interestingly Chrome keeps folders open until a click outside or ESC key press).
  • The delay timeout speed should be tweaked for the optimal UX.
  • When opening another folder on the same level any existing folder popup on that level should be closed immediately.

Many things here differ from the Chrome UX because Chromium is designed for good a11y however this extension favours speed.

If a search is active and a tabs event fires, the "Open Tabs" section is updated without the search filter. It's easy to replicate (and especially annoying) on initial browser load while all the previous open tabs are loading.

Version: v0.15.0

• Folder popup width often too narrow resulting in bookmark item title text being truncated
• Folder popup min and max width
• Nested folders with long scrollable lists can result in the scrollbars rendering strangely (although this may be an issue due to my local browser's experimental flag options)
• Subfolders are missing a caret icon (to help differentiate folders from links)

Hey man!

Love this extension. It's absolutely amazing, super fast and comfy. I follow ur code changes. This tool increases my productivity by removing distracting bookmarks bar, and show very fast what top sites i visit since it's shown on the new tab page.

However I believe more people should know about it!

The current image in the webstore https://chrome.google.com/webstore/detail/new-tab/cpcibnbdmpmcmnkhoiilpnlaepkepknb
however is very ugly; low resolution and doesnt show all capabilities! Could you perhaps change it to a higher resolution image (or multiple images) and perhaps show dark mode too? Or even better would be a GIF there showing new tab with its capabilties (change layout, themes etc).

It would definitely 'sell' this extension more I think.

Anyways, thanks.

Although the settings view is functional, it's not so pretty and could be more strightforward. Adding a little text documenting what's going on would probably be helpful too.

When opening multiple subfolders it's possible for the folder to rendered partially off-screen. Might need to add some logic to check if the folder is within the viewport bounds on open.

Will be good to configure the order of elements on the page.
I have information about all tabs in tabs anyway. :)

In the theme of trying to make everything in this project fast, it would be nice if the unit/functional tests were also made faster. Although jsdom is widely used and stable, it's also a little slow to initialise. Switching to happy-dom would greatly speed things up.

Even though Happy DOM is less used in the wild, they still strive to make it accurate. Anyway once we have [more] e2e tests, those will provide strong validation that our code is working as expected.

This is currently blocked because of issues within Happy DOM; their TreeWalker implementation is currently broken (our JS "framework" stage1, abuses TreeWalker internally). I'll update this issue once I've made a bug report on their repo.

Now that #1151 is merged we have bookmark folder popup position that is "good enough" for general use but the experience is not ideal in all scenarios.

For context, "top level" means a folder is on the bookmark bar itself and not nested inside another folder.

Folder popup position scenarios

1. Normal/default position
   • Top level: Show below the parent
   • Nested: Show beside the parent (on the right side)
2. Overflowing viewport to the right
   • Top level: Align the popup to the right edge of the viewport
   • Nested: Show beside the parent (on the left side)
     • Subsequent nested folder popups should also open to the left
       • At this point if a popup overflows to the left of the viewport then open to the right of the parent
3. Overflowing viewport both left and right
   • If the viewport is very narrow and the popup overflows on both sides there's basically nothing we can do. In this case the user will need to use the native bookmark bar or bookmark manager.

The current popup position logic from #1151 covers everything other than opening subsequent nested folder popups to the left (and then to the right if overflowing the left edge of the viewport).

Other issues

• Popups remain in place when the parent is scrolled. Native chrome closes the popup upon scrolling the parent, perhaps we should do the same. TBH it's not such a big deal though.

At random times new tab shows a white background as if the light theme was set. However it says dark theme is in use in the settings.

This is really annoying since it hurts my eyes haha. I don't know why or when this happens but perhaps someone else has had it too?

Version: 0.18, not from chrome webstore but self build using npm build

Durring the last big refactor I commented out the existing bookmark bar overflow code as I wasn't very happy with. How bookmark sub folders work needs to be completely refactored so as part of that work we should also write a new way to handle overflow.

TODO: Find some good virtual list implementations for insperation.

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Location: .github/renovate.json
Error type: Invalid JSON (parsing failed)
Message: Syntax error: expecting end of expression or separator near "] // "b

The LinkItem image padding is currently added if there's a title; class="{_node.title && 'pad'}". No title means _node.title === undefined and no padding is added, which is what we want. However, on some systems Chome returns a space character when there is no title, breaking the logic.

We need to figure out what's causing this difference between systems and change the logic to still work for both. This needs to be as high performance as possible since it's normally repeated many times on page load.

Known working system: Arch Linux + Chrome dev channel, version 70.0.3538.110
Known broken system: Ubuntu Linux + Chrome Version 72.0.3626.7 (Official Build) dev (64-bit)

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper App’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.

When the screen height is limited it's not possible to access all the bookmarks in a list because some are rendered off-screen. Need to implement some way of scrolling for access to all bookmarks.

The most recent Chrome Web Store submission was rejected due to a "missing privacy policy".

Sadly there's little notice about where the privacy policy should be and how to link to it. Do we really need a privacy policy or could filling out the store listing better resolve the issue? This all seems a bit strange because the extension explicitly does not collect any user data and is very strict about privacy. The extension does however use browser supplied data (only) about open tabs, history search, etc. Because of the ambiguity this needs deeper looking into.

Excerpt from the rejection notification email:

Item name: New Tab

Item ID: cpcibnbdmpmcmnkhoiilpnlaepkepknb

Violation(s):

User data privacy:

- Violation reference ID: Purple Nickel
- Violation: Privacy policy link is broken or unavailable
- How to rectify: Add a publicly accessible and working link to your privacy policy.
- Relevant section of the programme policy:
	If your product handles personal or sensitive user data, then your product must post a privacy policy. (learn more)

"learn more" link: https://developer.chrome.com/webstore/program_policies#userdata

More info:

• https://developer.chrome.com/docs/webstore/troubleshooting/#udp-prominent-disclosure
• https://developer.chrome.com/docs/webstore/user_data/

Hi,
I like the extension very much. It's more helpful than most other new tab pages. One thing i would like to have is a randomly changing unsplash background.

Is it possible to add it?

When using the extension with the white theme, the screen is flashing black shortly when loading the new tab page.

Maybe CSS for the black theme is applied on load and the white theme CSS is overwriting it later on?

Example:

Before we can publish a new version on the Chrome Web Store it's now required to have screenshots and privacy info. This would be a good opportunity to rewrite the content etc. too.

Related: #259

When I click on it, it closes the new tab. It shouldn't be visible by itself

The project sounds cool! It could use some example screenshots though - both in the readme and in the extension store.

There's not much motivation to install something and try it out without an idea of what you'll be getting.