maxigimenez / angular-atomic-notify Goto Github PK
View Code? Open in Web Editor NEWAtomic growl notifications for angular.js applications
Home Page: http://maxigimenez.github.io/angular-atomic-notify/
License: MIT License
Atomic growl notifications for angular.js applications
Home Page: http://maxigimenez.github.io/angular-atomic-notify/
License: MIT License
please push the latest version to npm that uses array injection.
When I try to compress the lib using uglifier with mangle: true I get the error "Unknown Provider", because during the compression "$scope" parameter name has been changing here https://github.com/maxigimenez/angular-atomic-notify/blob/master/src/angular-atomic-notify.js#L102
The possible solution is to use DI in this line https://github.com/maxigimenez/angular-atomic-notify/blob/master/src/angular-atomic-notify.js#L128
Like that ['$scope', controller]
I also can reproduce the problem even without a compression just using ng-strict-di directive. Then it says "Error: [$injector:strictdi] function($scope) is not using explicit annotation and cannot be invoked in strict mode"
Should I create a PR or you can fix it by yourself?
Hey, this notification looks great but running into some issues when adding to my own site.
[Error] Error: undefined is not an object (evaluating 'directive.addItem')
displayNotify@https://patrickziegler.se/fitnessbuddy/js/angular-atomic-notify.min.js:1:522
info@https://patrickziegler.se/fitnessbuddy/js/angular-atomic-notify.min.js:1:1323
https://patrickziegler.se/fitnessbuddy/js/script.js:175:32
https://cdnjs.cloudflare.com/ajax/libs/angular.js/1.3.15/angular.min.js:112:114
$eval@https://cdnjs.cloudflare.com/ajax/libs/angular.js/1.3.15/angular.min.js:126:15
$digest@https://cdnjs.cloudflare.com/ajax/libs/angular.js/1.3.15/angular.min.js:123:111
$apply@https://cdnjs.cloudflare.com/ajax/libs/angular.js/1.3.15/angular.min.js:126:300
https://cdnjs.cloudflare.com/ajax/libs/angular.js/1.3.15/angular.min.js:139:9
e@https://cdnjs.cloudflare.com/ajax/libs/angular.js/1.3.15/angular.min.js:40:79
https://cdnjs.cloudflare.com/ajax/libs/angular.js/1.3.15/angular.min.js:44:156
(anonymous function) (angular.min.js, line 102)
(anonymous function) (angular.min.js, line 76)
(anonymous function) (angular.min.js, line 112)
$eval (angular.min.js, line 126)
$digest (angular.min.js, line 123)
$apply (angular.min.js, line 126)
(anonymous function) (angular.min.js, line 139)
e (angular.min.js, line 40)
(anonymous function) (angular.min.js, line 44)
All I am doing is calling atomicNotifyService.info('Yes, this is the default notification :D');
from within my angular controller.
Any idea?
The code is at patrickziegler.se/fitnessbuddy
Please.
(suggestion : github pages)
I'm unable to uglify the source because the 'ngAtomicNotify' directive is not specified using the array syntax. It should look similar to the following:
.directive('ngAtomicNotify', ['$compile', '$timeout', function($compile, $timeout){ ...
Could you please put in a fix and push an update to bower?
I tried this but i am getting ur directive undefined when it gets to "displayNotify" function in your service.
On further debugging i found that
angular.element('ng-atomic-notify').isolateScope() return nothing.
FYI all my view and controller are under parent controller
Update:- The issue is if we use this directive under parent controller it doesn't work coz of scope issue but in a lot of cases you would maintain ur whole application via one parent controller not via rootscope.
I will wait for your thoughts
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.