Code Monkey home page Code Monkey logo

atom-language-smarty's People

Stargazers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar avatar avatar avatar

Forkers

cyberj marcusy3k dafrok srj9 tomwagner mfmoura djmassive avatec

atom-language-smarty's Issues

{literal} tag mess with quotations

When using the {literal} tag, to put smarty variables on javascript over the tpl, the syntax highlight messes up, making all the rest of the buffer highlighted as a string,

Object.extname is deprecated.

Argument to path.extname must be a string

Object.extname (/Applications/Atom.app/Contents/Resources/app.asar/src/electron-shims.js:20:10)
<unknown> (/Users/nsingleton/.atom/packages/language-smarty/index.coffee:9:22)
Workspace.observeTextEditors (/Applications/Atom.app/Contents/Resources/app.asar/src/workspace.js:329:9)
<unknown> (/Users/nsingleton/.atom/packages/language-smarty/index.coffee:8:33)
Function.module.exports.Emitter.simpleDispatch (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:25:14)
Emitter.emit (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:129:28)

Unbalanced or escaped quotes mess up highlighting

When using functions that have unbalanced quotes (but still valid code) the highlighting interprets everything as a string afterwards.

Screenshots

  • double quote within single quotes

test1

  • escaped double quote within double quotes

test2

Maximum call stack size exceeded on new window launch

Getting this with the latest version installed:
Maximum call stack size exceeded

  1. Open Atom

Atom Version: 1.1.0
System: Mac OS X 10.11.1
Thrown From: language-smarty package, v1.3.0

Stack Trace

Failed to activate the language-smarty package

At Maximum call stack size exceeded

RangeError: Maximum call stack size exceeded
    at Package.module.exports.Package.activate (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:201:34)
    at PackageManager.module.exports.PackageManager.activatePackage (/Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:474:21)
    at Object.module.exports.activate (/Users/timkelty/.atom/packages/language-smarty/index.coffee:3:21)
    at Package.module.exports.Package.activateNow (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:232:19)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/package.js:212:32
    at Package.module.exports.Package.measure (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:153:15)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/package.js:205:26
    at Package.module.exports.Package.activate (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:201:34)
    at PackageManager.module.exports.PackageManager.activatePackage (/Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:474:21)
    at Object.module.exports.activate (/Users/timkelty/.atom/packages/language-smarty/index.coffee:3:21)
    at Package.module.exports.Package.activateNow (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:232:19)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/package.js:212:32
    at Package.module.exports.Package.measure (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:153:15)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/package.js:205:26
    at Package.module.exports.Package.activate (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:201:34)
    at PackageManager.module.exports.PackageManager.activatePackage (/Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:474:21)

Commands

Config

{
  "core": {
    "themes": [
      "atom-dark-ui",
      "tomorrow-night-eighties-syntax"
    ],
    "excludeVcsIgnoredPaths": false,
    "disabledPackages": [
      "linter-csslint"
    ]
  }
}

Installed Packages

# User
Sublime-Style-Column-Selection, v1.3.0
atom-alignment, v0.12.1
docblockr, v0.7.3
editorconfig, v1.2.2
emmet, v2.3.14
file-type-icons, v0.7.3
file-types, v0.5.1
html-entities, v0.4.0
javascript-snippets, v1.0.0
js-autoimport, v0.5.1
language-apache, v1.3.0
language-ini, v1.14.0
language-nunjucks, v2.0.0
linter, v1.10.0
linter-js-yaml, v1.2.0
linter-jshint, v1.2.1
linter-php, v1.1.0
linter-tidy, v1.0.1
linter-xmllint, v0.0.7
markdown-preview-plus, v2.2.2
react, v0.12.10
set-syntax, v0.3.0
synced-sidebar, v0.4.2
tomorrow-night-eighties-syntax, v0.9.0

# Dev
No dev packages

Failed to activate the language-smarty package

[Enter steps to reproduce below:]

  1. ...
  2. ...

Atom Version: 0.199.0
System: Mac OS X 10.10.3
Thrown From: language-smarty package, v1.0.0

Stack Trace

Failed to activate the language-smarty package

At Cannot read property 'scopeName' of undefined

TypeError: Cannot read property 'scopeName' of undefined
    at TokenizedBuffer.module.exports.TokenizedBuffer.setGrammar (/Applications/Atom.app/Contents/Resources/app.asar/src/tokenized-buffer.js:124:30)
    at DisplayBuffer.module.exports.DisplayBuffer.setGrammar (/Applications/Atom.app/Contents/Resources/app.asar/src/display-buffer.js:1076:35)
    at TextEditor.module.exports.TextEditor.setGrammar (/Applications/Atom.app/Contents/Resources/app.asar/src/text-editor.js:2224:33)
    at /Users/hermanndettmann/.atom/packages/language-smarty/index.coffee:8:25
    at Workspace.module.exports.Workspace.observeTextEditors (/Applications/Atom.app/Contents/Resources/app.asar/src/workspace.js:267:9)
    at Object.module.exports.activate (/Users/hermanndettmann/.atom/packages/language-smarty/index.coffee:6:29)
    at Package.module.exports.Package.activateNow (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:238:19)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/package.js:219:30
    at Package.module.exports.Package.measure (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:163:15)
    at Package.module.exports.Package.activate (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:211:14)

Commands

     -2:34.3.0 fuzzy-finder:toggle-file-finder (atom-text-editor.editor.is-focused)
  2x -2:30.7.0 core:move-down (atom-text-editor.editor.mini.is-focused)
     -2:25.9.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -2:17.4.0 deprecation-cop:view (atom-workspace.workspace.scrollbars-visible-always.theme-one-dark-syntax.theme-one-dark-ui)
     -1:33.4.0 fuzzy-finder:toggle-file-finder (atom-text-editor.editor.is-focused)
     -1:27.6.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -1:07.9.0 fuzzy-finder:toggle-file-finder (atom-text-editor.editor.is-focused)
     -0:57.3.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -0:39.6.0 command-palette:toggle (atom-text-editor.editor.is-focused)
  5x -0:35.1.0 core:move-down (atom-text-editor.editor.mini.is-focused)
     -0:33.9.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -0:33.9.0 settings-view:install-packages-and-themes (atom-text-editor.editor)
     -0:27 core:confirm (atom-text-editor.editor.mini.is-focused)

Config

{
  "core": {}
}

Installed Packages

# User
Atom-Syntax-highlighting-for-Sass, v0.5.0
color-picker, v1.7.0
emmet, v2.3.9
language-smarty, v1.0.0

# Dev
No dev packages

Doesn't format smarty syntax inside JS script element

I'm having an issue where I have smarty comments and statements inside a html <script type="text/javascript"> tag and the syntax is no longer colored or highlighted correctly. Simple example below. Another thing I'm encountering is mismatched quotes in a comment, again inside a script tag, will highlight the rest of the file's text red.

screen shot 2017-04-26 at 11 46 07 am
screen shot 2017-04-27 at 12 07 33 pm

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.