https://maurodatamapper.github.io

Add link above to home page for all instances, in BIG BOLD Letters.. possibly flashing with a giphy so you don't miss it.

Describe the bug
End to end tests can fail on development instance because of inconsistency between buttons for logging in and out.

To Reproduce

1. Setup UI to run as: npm run start -- --post 8082
2. In the mdm-end-to-end-testing repo:
   1. Run npm run webdriver-start to start the Selenium web driver
   2. Run in another process npm run build then npm run test to start the e2e tests.

Expected behavior
All tests should pass with a fully green report.

Additional context
The issue is because the test steps are searching for a "Log in" button on the modal form to submit, when the actual text is "Login".

This should be fixed in the UI as follows:

1. Ensure all buttons for logging in are labelled "Log in", matching casing and the included space.
2. Ensure all buttons for logging out are labelled "Log out", matching casing and the included space.

Describe the bug
As a user i should be able to edit the Terminology title at the moment i have no means to edit the title

Describe the bug
After importing a data model, I get a 404 not found when the UI tries to redirect to the imported model

To Reproduce
Steps to reproduce the behavior:
Import a model using JSON importer (also same result with CSV importer). See attached file. After import, 404.

Expected behavior
Redirect to imported model

Screenshots

Desktop (please complete the following information):
Mac OS, Safari

Additional context
Latest Develop branches of core and ui

In the old metadata catalogue, they used to open in a new tab, but I think we've moved away from that now.

Describe the bug
There is a ReferenceType DataType which points to a DataClass.
When that DC is deleted the RT is as well, however the UI still shows the RT existing until you click on it and get an error.

To Reproduce
Steps to reproduce the behavior:

1. Create or copy a DC with a RT (complex model -> parent DC) to another model
2. There will be an addtl DT in the types page
3. Delete the parent DC you copied
4. The DC is gone from schemes but the DT still shows

Expected behavior
DTs need to be refreshed after a DC deletion.

In the same light, deleting a DT will delete all DEs which it is used for, therefore we should refresh the scheme page as well

Issue

The SecurityHandlerService.elementAccess() method returns different objects depending on the domain type of the catalogue. However, this poses some long-term issues:

1. How do we know what access properties are available to the object returned? Currently, these must be inspected from the SecurityHandlerService code.
2. What if more domain types are added?

Suggestion

The SecurityHandlerService is passed a catalogue item which should, at the very least, have the same properties/traits as a Securable type. So it would make more sense to:

1. Define one CatalogueItemAccess type with all the boolean properties related to access permissions, e.g. showEdit, canDelete etc
2. Change SecurityHandlerService.elementAccess() to flatten Securable.availableActions array to these access flags in one go.

If a domain type does not require all the access flag, then these would simply resolve to false and can be ignored. This means multiple functions are no longer needed to define what actions can be performed.

Finalise has disappeared from the reference data models

Describe the bug
I added a favourite DM and then selected the Favourites tab and got a 404

Describe the bug
When branching a model, that took more then 30 mins, I received a server error. Used inspector to see timeout error, however there was no information in the details grid view.
'''Request
PUT /mauro-data-mapper/api/dataModels/73d373d5-8223-4fd0-86cb-e9a9acc8844b/newBranchModelVersion HTTP/1.1
Content-Type: application/json
Pragma: no-cache
Accept: application/json, text/plain, /
Accept-Language: en-gb
Accept-Encoding: gzip, deflate, br
Cache-Control: no-cache
Host: oxnetdwa02.oxnet.nhs.uk
Origin: https://oxnetdwa02.oxnet.nhs.uk
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/14.1 Safari/605.1.15
Referer: https://oxnetdwa02.oxnet.nhs.uk/mauro-data-mapper/
Content-Length: 30
Connection: keep-alive
Cookie: JSESSIONID=D924061337AF0D22E109CD931200B6CB; _ga=GA1.3.721931879.1620143590; _gid=GA1.3.1515164793.1620143590
Response
HTTP/1.1 504 Gateway Time-out
Date: Wed, 05 May 2021 10:15:29 GMT
Content-Type: text/html
Connection: keep-alive
Cache-Control: no-store, no-cache, must-revalidate
Content-Length: 192
Server: nginx/1.14.0 (Ubuntu)'''

To Reproduce
Steps to reproduce the behavior:
Go to 'OUH instance'
Branch a large model - wait for it to receive a server error - open details, see that there is nothing there

Desktop (please complete the following information):

OS: Mac OS 11.3.1
Browser Safari
Version 14.1
Additional context
I've only tried this in the OUH instance, will test others when I get a chance.

Describe the bug
When trying to export Reference Data Models an error with renderer prevents it from completing

filtering doesn't allow me to enter text to filter

Describe the bug
When looking at a data element in a draft data model, the "Add new profile" option does not appear in the dropdown on the profile page

Expected behavior
Being able to add a new profile to a Data Element

At the moment you get into an inconsistent state where no profile is set

Describe the bug
When viewing the tree there are muliple Main versions, where they have been branched as a documentation version or the like. This is causing confusion when branching the models finalised models. this is in the CDW instance of MDM, there are two of the "same" models in the tree, but 4 'main' branches listed in the dropdown.

In looking at the code, one of the 'main' versions is a documentation version but has been over written? Talked to @olliefreeman about it this afternoon.

To Reproduce
Steps to reproduce the behavior:

1. Go to OUH instance, search for modules, view drop down, open inspector to see differences.

Expected behavior
I would expect their to be 1 main model and the branches that come off that finalised version, one of which being documentation. In addition in the dropdown I would either see only thoe visible in the tree or those that have been superseded marked as such.

Screenshots

    "domainType": "DataModel",
    "label": "modules",
    "availableActions": [
        "show",
        "createNewVersions",
        "newForkModel",
        "comment",
        "newModelVersion",
        "newDocumentationVersion",
        "newBranchModelVersion",
        "softDelete",
        "delete"
    ],
    "lastUpdated": "2020-03-18T14:43:05.134Z",
    "type": "Data Asset",
    "branchName": "main",
    "documentationVersion": "2.0.0",
    "finalised": true,
    "readableByEveryone": false,
    "readableByAuthenticatedUsers": false,
    "dateFinalised": "2020-03-18T14:39:16.667Z",
    "modelVersion": "1.0.0",
    "authority": {
        "id": "4dacb991-c0cb-4d46-b865-fea67a8f7d37",
        "url": "https://oxnetdwa02.oxnet.nhs.uk/",
        "label": "OUH-CDW"
    }
}

Desktop (please complete the following information):

• OS: Mac OS 11.3.1
• Browser safari
• Version: 14.1

Data Type drop doesn't allow for editing it resets to its oringal value

Import button in Data Product instance and OUH instance not working.

go to comments section and add multiply comment, then try reorder notice nothing happens

When the relationships for a term are retrieved, the call should pass the parameter type=source. This will ensure that the correct relationships are displayed... at the moment all relationships where the current term is the target, which leads to a confusing display.

Click on a terminology and select help it shows a not found error

Describe the bug
If MDM_UI_THEME_NAME is set to an empty string then the UI cannot load any theme resulting in a 404 on assets/themes//logo.png

To Reproduce
Set MDM_UI_THEME_NAME='' then run or build and run the ui

Expected behavior
If the env variable is blank or null or not present then we should use the default theme, we should also probably handle an unknown theme to default to the "default" theme incase someone puts junk in.

Screenshots

Describe the bug
Deleting a Data Element greater then 1 level deep throughs and error.

When the delete is completed and successful the redirect appears to fail and shows the page not found screen

Describe the bug
When clearing the search bar, the tree view stays on the filtered view rather then reverting back.

To Reproduce
Steps to reproduce the behavior:

1. Go to 'OUH instance'
2. Click on 'the search bar' -- search for a model, clear the search bar

Expected behavior
I would expect that when the search bar is cleared of the search the tree would revert back to the main (unfiltered) tree view
Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: Mac OS 11.3.1
• Browser Safari
• Version 14.1

Additional context
I've only tried this in the OUH instance, will test others when I get a chance.

Describe the bug
On a Data Model go to the links view and click on suggested links, select and target and click the suggest links button a 404 is returned

Describe the bug
When creating a model the following values are optional but they're marked as mandatory

• author
• organisation

When creating a new DataModel you should not have to select default data types to add. It is an optional thing for users to do if they want

To Reproduce
Steps to reproduce the behavior:

1. Try to create a DataModel and get through the creation process without filling out any of the above

Issue

The current BroadcastService broadcasts messages to other unrelated components as follows:

• Send a message name as a string
• Send optional data with the message as any data

This does introduce technical debt because of the copy/paste aspect of broadcasting/subscribing to these events. For example, to trigger the model tree to reload:

service.broadcast('$reloadFoldersTree');

If this were mispelled or the message name was changed in the future, re-testing this would have to be manual instead of found during compile time.

Suggestion

It is possible to create a type-safe broadcast service where:

• Message names are defined as constants
• Expected data can be defined with generics

An example of interface for this could be:

export enum BroadcastEvent {
  ReloadFolderTree,
  // etc...
}

export class BroadcastMessage<T> {
  constructor(public event: BroadcastEvent, public data?: T) { }
}

export class BroadcastService {
  private handler = new Subject<BroadcastMessage<any>>();

  // Call this to subscribe to certain events
  on<T>(event: BroadcastEvent): Observable<T> { }

  // Call this to dispatch/broadcast events
  dispatch<T>(event: BroadcastEvent, data?: T): void { }
}

Tasks

• Refactor the BroadcastService to use the type-safe methods
• Add the necessary BroadcastEvent enums. Search the codebase for all instances of the string name usage as a start
• Replace the old string broadcast names with BroadcastEvent
• Ensure all subscription points still work

The attachments tab is missing from the data model catalogue item

When you import a model (data model, terminology, etc) using the UI, there's a field to decide which folder the newly created model(s) are imported into. If a folder is selected in the tree, it would be nice if the folder selector could default to this location.

Click on a Terminology then click on export and select xml, using dev tool look at errors

Describe the bug
Add Link Fails when adding custom Links

To Reproduce
Steps to reproduce the behavior:
Go To A DM
Click on Context
Click Add link
Fill in required info click green tick

Notice it doesn't save

When viewing a terminology, the "Add new profile..." option is not appearing as part of the dropdown to view other profiles

Dependabot has noticed we have dependencies on versions of codemirror and loads libraries, which have security vulnerabilities. We need to update these two dependencies to the latest version

More details here: https://github.com/MauroDataMapper/mdm-ui/security/dependabot

Using the Bootstrap dataclasses delete SourceFlowDataModel the following error is returned

  "headers": {
    "normalizedNames": {},
    "lazyUpdate": null
  },
  "status": 500,
  "statusText": "OK",
  "url": "http://localhost:8080/api/dataModels/6aaf8e1e-b91e-415c-9d86-e4fc2ccc87f8?permanent=true",
  "ok": false,
  "name": "HttpErrorResponse",
  "message": "Http failure response for http://localhost:8080/api/dataModels/6aaf8e1e-b91e-415c-9d86-e4fc2ccc87f8?permanent=true: 500 OK",
  "error": {
    "status": 500,
    "reason": "Internal Server Error",
    "errorCode": "UEX--",
    "message": "No signature of method: uk.ac.ox.softeng.maurodatamapper.dataflow.component.DataElementComponentService.deleteAllFacetsByCatalogueItemIds() is applicable for argument types: (ArrayList, String) values: [[24a4dd67-2548-4acd-bd2c-0ba977649a69, 32772381-b2c8-44ee-b1a4-1d2fee0087aa, ...], ...]",
    "path": "/api/dataModels/6aaf8e1e-b91e-415c-9d86-e4fc2ccc87f8",
    "devMode": true,
    "version": "4.5.0-SNAPSHOT",
    "exception": {
      "type": "MissingMethodException",
      "message": "No signature of method: uk.ac.ox.softeng.maurodatamapper.dataflow.component.DataElementComponentService.deleteAllFacetsByCatalogueItemIds() is applicable for argument types: (ArrayList, String) values: [[24a4dd67-2548-4acd-bd2c-0ba977649a69, 32772381-b2c8-44ee-b1a4-1d2fee0087aa, ...], ...]",
      "stacktrace": [
        "uk.ac.ox.softeng.maurodatamapper.dataflow.component.DataElementComponentService.$tt__dataElementComponentService_deleteAllByModelId(DataElementComponentService.groovy:123)",
        "jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)",
        "jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)",
        "jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)",
        "jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)",
        "grails.gorm.transactions.GrailsTransactionTemplate$2.doInTransaction(GrailsTransactionTemplate.groovy:94)",
        "org.springframework.transaction.support.TransactionTemplate.execute(TransactionTemplate.java:140)",
        "grails.gorm.transactions.GrailsTransactionTemplate.execute(GrailsTransactionTemplate.groovy:91)",
        "uk.ac.ox.softeng.maurodatamapper.dataflow.component.DataClassComponentService.$tt__dataClassComponentService_deleteAllByModelId(DataClassComponentService.groovy:115)",
        "jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)",
        "jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)",
        "jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)",
        "jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)",
        "grails.gorm.transactions.GrailsTransactionTemplate$2.doInTransaction(GrailsTransactionTemplate.groovy:94)",
        "org.springframework.transaction.support.TransactionTemplate.execute(TransactionTemplate.java:140)",
        "grails.gorm.transactions.GrailsTransactionTemplate.execute(GrailsTransactionTemplate.groovy:91)",
        "uk.ac.ox.softeng.maurodatamapper.dataflow.DataFlowService.$tt__dataFlowService_deleteAllByModelId(DataFlowService.groovy:103)",
        "jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)",
        "jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)",
        "jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)",
        "jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)",
        "grails.gorm.transactions.GrailsTransactionTemplate$2.doInTransaction(GrailsTransactionTemplate.groovy:94)",
        "org.springframework.transaction.support.TransactionTemplate.execute(TransactionTemplate.java:140)",
        "grails.gorm.transactions.GrailsTransactionTemplate.execute(GrailsTransactionTemplate.groovy:91)",
        "uk.ac.ox.softeng.maurodatamapper.datamodel.DataModelService$__tt__dataModelService_deleteModelAndContent_closure93.doCall(DataModelService.groovy:352)",
        "jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)",
        "jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)",
        "uk.ac.ox.softeng.maurodatamapper.datamodel.DataModelService.$tt__dataModelService_deleteModelAndContent(DataModelService.groovy:347)",
        "jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)",
        "jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)",
        "jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)",
        "jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)",
        "grails.gorm.transactions.GrailsTransactionTemplate$2.doInTransaction(GrailsTransactionTemplate.groovy:94)",
        "org.springframework.transaction.support.TransactionTemplate.execute(TransactionTemplate.java:140)",
        "grails.gorm.transactions.GrailsTransactionTemplate.execute(GrailsTransactionTemplate.groovy:91)",
        "uk.ac.ox.softeng.maurodatamapper.datamodel.DataModelService.$tt__dataModelService_delete(DataModelService.groovy:161)",
        "jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)",
        "jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)",
        "jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)",
        "jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)",
        "grails.gorm.transactions.GrailsTransactionTemplate$2.doInTransaction(GrailsTransactionTemplate.groovy:94)",
        "org.springframework.transaction.support.TransactionTemplate.execute(TransactionTemplate.java:140)",
        "grails.gorm.transactions.GrailsTransactionTemplate.execute(GrailsTransactionTemplate.groovy:91)",
        "uk.ac.ox.softeng.maurodatamapper.core.model.ModelService.permanentDeleteModel(ModelService.groovy:166)",
        "uk.ac.ox.softeng.maurodatamapper.core.controller.ModelController.$tt__modelController_delete(ModelController.groovy:144)",
        "jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)",
        "jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)",
        "jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)",
        "jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)",
        "grails.gorm.transactions.GrailsTransactionTemplate$2.doInTransaction(GrailsTransactionTemplate.groovy:94)",
        "org.springframework.transaction.support.TransactionTemplate.execute(TransactionTemplate.java:140)",
        "grails.gorm.transactions.GrailsTransactionTemplate.execute(GrailsTransactionTemplate.groovy:91)",
        "jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)",
        "jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)",
        "org.grails.core.DefaultGrailsControllerClass$ReflectionInvoker.invoke(DefaultGrailsControllerClass.java:211)",
        "org.grails.core.DefaultGrailsControllerClass.invoke(DefaultGrailsControllerClass.java:188)",
        "org.grails.web.mapping.mvc.UrlMappingsInfoHandlerAdapter.handle(UrlMappingsInfoHandlerAdapter.groovy:90)",
        "org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:1040)",
        "org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:943)",
        "org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:1006)",
        "org.springframework.web.servlet.FrameworkServlet.doDelete(FrameworkServlet.java:931)",
        "org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:883)",
        "org.grails.web.servlet.mvc.GrailsWebRequestFilter.doFilterInternal(GrailsWebRequestFilter.java:77)",
        "org.grails.web.filters.HiddenHttpMethodFilter.doFilterInternal(HiddenHttpMethodFilter.java:67)",
        "java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)",
        "java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)",
        "java.lang.Thread.run(Thread.java:835)"
      ]
    }
  }
}

After adding a new classifier the reverts to the model view when it should remain on the classifier view

I have a draft terminology - 'delete' is coming from the back end as an available action, but the delete option isn't appearing in the action dropdown.

There is a lot of redundant code within the detailed views of most catalogue items, to improve code readable this should be reviewed and refactored to make the code more clean

Describe the bug
Unable edit elements or data in reference data types

Describe the bug
Selecting Public on the security popup adds new user and doesn't make the DM public

When you export a model, the presentation of the download links could be improved - especially when multiple files are downloaded.

Describe the bug
Upon a successful import of a reference data model the tree should refresh and display the newly imported ref DM but it doesn't it stick with the screen and appears to be broken

The NOTICE file (and code file headers) still have the old notice file on (with an old date). Needs updating across the board.

When trying to additional comments on an existing comment i click the button and nothing happens

Trying to merge anything but a DM fails