mattngc / raysect_mayavi Goto Github PK

Sorry, I know this repo is experimental, but I don't understand the default plot_kwargs in the TriangularMeshSource. With transparent:True and opacity:0, I get a blank screen. If I hardcode (I don't seem to see how to set otherwise) to transparent:False and opacity:1, I actually get a gray triangulated mesh object. Am I doing something wrong?

I would like to transform rest of the methods constructing geometric primitives and mesh primitive to classes as it was done for cylindrical primitives (lenses, cylinder). There are two reasons. Now there is different approach taken for primitives, which I think could be confusion and also ot will allow the plotting mechanism to be changed to better treat different "objects" as for example primitives and ray trajectories. Each class can hold metadata about its plot properties and can add itself to a figure using preferred plotting function.

The _parse_nodes method now can't handle correctly any class inherited from the Node class and can't handle primitives being parents to other primitives, see the if statement. I think a better solution could be:

        if isinstance(child, Primitive):
            _parse_nodes(child, mesh_list)
            mesh_list.append((to_mesh(child), child.meta))
        elif isinstance(child, Observer):
            return
        elif isinstance(child, Node):
            _parse_nodes(child, mesh_list)

Also, I think it could be made a function returning a list of meshes instead of changing a list.

I've discovered Pyvista package, which is an alternative to Mayavi. The advantage could be it is nicely integrable with panel. Pyvista seems to be a nice way how to use the visualisation inside jupyter and more importantly also remotly. The integration with panel can offer the possibility to integrate the visualisation into panel dashboards.

@mattngc feel free to assign this to me, I have most of the work done.

This library might be better for mesh generation.

https://gmsh.info