Code Monkey home page Code Monkey logo

Comments (7)

bh213 avatar bh213 commented on July 28, 2024 1

I created a PR, please take a look, at very least I'll have to add a few tests...

from exifreader.

bh213 avatar bh213 commented on July 28, 2024

Seems this jpeg uses JFIF, not sure if this is something this library is supposed to support?

from exifreader.

mattiasw avatar mattiasw commented on July 28, 2024

Hi! No problem with JFIF, however, from what I understand most of those fields are from the ICC color profile which is not supported. I haven't looked at it enough to know how much work it would be to implement it, but I guess it would be possible. Will have a deeper look later on.

from exifreader.

bh213 avatar bh213 commented on July 28, 2024

@mattiasw I mostly added ICC profile parsing to this library, let me know if you would be interesting in accepting PR with these changes.

Current work is here (in master, I'll squash commits later): https://github.com/bh213/ExifReader/commits/master

I still have to refactor tags parsing into separate class with better names, add a few tests & update typescript definitions.

from exifreader.

mattiasw avatar mattiasw commented on July 28, 2024

Nice! I would definitely be interested in a PR for those changes.

from exifreader.

mattiasw avatar mattiasw commented on July 28, 2024

I'll try to have a look over the weekend.

from exifreader.

mattiasw avatar mattiasw commented on July 28, 2024

Implemented in #59.

from exifreader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.