Incorrect exposure time reported for description about exifreader HOT 9 CLOSED

Have upgraded locally and can confirm for my above image the time is now showing as 1.5s. Closing this as resolved.

from exifreader.

Hi! I seem to have no test images with this kind of exposure time. That could be why I haven't noticed it before. So it would be helpful to get an example picture. Feel free to crop to 1x1 and remove any sensitive metadata.

from exifreader.

Thanks for looking at this so quickly!

Attaching an example image with 1.5s exposure time.

from exifreader.

It seems like most times under 1s are expressed as rational expressions of 1/x. I've now logged out all images where tags['ExposureTime'].value[0] !== 1 - and have a case of the description being wrong below 1s too:

{ id: 33434, value: [ 8, 10 ], description: '1/1' }

I think this should probably have a value of 0.8?

Thinking about it more, I suspect this bug might exist for all values > 0.5s and <2s? Or possibly any time over 0.5s where it's not a whole number of seconds?

from exifreader.

Yeah, that's deliberate. It's a bit tricky to guess how people want this value to be represented. From earlier discussions, values below 1 have been preferred to be expressed like 1/800 e.g. The issue with that is that the 800 is not always exactly 800, so there is some rounding (I think there was a good example where this was wanted). If it's smaller numbers this will get weird as you've noticed. If I'm uncertain I usually try to mimic how exiftool does this but you are showing numbers I haven't come in contact with before. :-) It would be great if you could run your images with weird descriptions through exiftool (exiftool -G image.jpg) and look at the [EXIF] value for Exposure Time and post the results here. I did it for the image above and it unsurprisingly gives me 1.5. This seems like an obvious change to make. But it would be nice to have a good set of rules for the other situations too.

from exifreader.

Sure thing! Exif tool gives:

[EXIF]          Exposure Time                   : 0.8

FWIW, for anything above 0.5s I don't think you can reasonably output a fraction - 4/5s just doesn't sound right - I think all cameras would say 0.8s. I suspect you could remove all rounding for any times over 0.5s?

from exifreader.

Let's try that. There is a PR now if you want to have a look: #271

from exifreader.

Busy week. But now this is published as version 4.21.0. See PR for more details: #271

from exifreader.

Thanks for resolving this so quickly!

from exifreader.