matthiware / financialmodelingprep.net Goto Github PK

• Check if it makes sense to use https://github.com/reactiveui/refit
• Refactor to use Refit bindings

Hi Matthi,

Can you confirm this with me? It looks like the period enum isn't working as a parameter

It seems like the parameters are case sensitive:

doesn't work (note capital Q in Quarter)
https://financialmodelingprep.com/api/v3/analyst-estimates/APY.TO?period=Quarter&limit=22&apikey=abc
works:
https://financialmodelingprep.com/api/v3/analyst-estimates/APY.TO?period=quarter&limit=22&apikey=abc

When it doesn't work it seems to be returning the annual results and the period enum defaults to a capitalised string

It seems to be on all endpoints (or at least the couple I've tried)

There are some error on getting the enterprise values, for example with symbol AAPL you get the data, with ticket NNN you get the following json error:

System.Text.Json.JsonException: The JSON value could not be converted to System.Int64. Path: $[2].minusCashAndCashEquivalents | LineNumber: 24 | BytePositionInLine: 43.
---> System.FormatException: Either the JSON value is not in a supported format, or is out of bounds for an Int64.
at System.Text.Json.Utf8JsonReader.GetInt64()

Maybe you can change the type of the the following properties in classes
MatthiWare.FinancialModelingPrep.Model.CompanyValuation.EnterpriseValueResponse to double:

• AddTotalDebt
• MinusCashAndCashEquivalents

For some tickers like SHUR.BR the data for year 2018 contains null. As a result of this the deserialization fails.
All value fields on AnalystEstimateItem should be nullable.

Use Polly and https://github.com/Polly-Contrib/Polly.Contrib.WaitAndRetry/blob/master/src/Polly.Contrib.WaitAndRetry/Backoff.DecorrelatedJitterV2.cs

To make the transition to .NET 6 easier we should target both for now.
Eventually we can remove .NET 5 target.

Logging should be added in the integration tests but without exposing the API Keys in the log.

• Find a way to sanitize the logs before they end up in the GH Actions Output see roryprimrose/Neovolve.Logging.Xunit#115

See https://site.financialmodelingprep.com/developer/docs/#ESG-SCORE

https://github.com/adamralph/minver

In order to comply with the ToS of FMP we need to ensure a max of 10 requests per second is being send to the API.

• Rate limit the HttpClient
• Make max allowed requests/sec configurable (default 10)

Hi getting ERROR when calling this:
var test = api.CompanyValuation.GetBalanceSheetStatementAsync("TSLA", MatthiWare.FinancialModelingPrep.Model.Period.Quarter, 10000).Result;

May I ask you to fix this serialization ERROR?

System.Text.Json.JsonException: The JSON value could not be converted to System.Double. Path: $[52].othertotalStockholdersEquity | LineNumber: 2904 | BytePositionInLine: 39.
---> System.InvalidOperationException: Cannot get the value of a token type 'Null' as a number.
at System.Text.Json.Utf8JsonReader.TryGetDouble(Double& value)
at System.Text.Json.Utf8JsonReader.GetDouble()
at System.Text.Json.Serialization.Converters.DoubleConverter.ReadNumberWithCustomHandling(Utf8JsonReader& reader, JsonNumberHandling handling)
at System.Text.Json.Serialization.JsonConverter1.TryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, T& value) at System.Text.Json.JsonPropertyInfo1.ReadJsonAndSetMember(Object obj, ReadStack& state, Utf8JsonReader& reader)
at System.Text.Json.Serialization.Converters.ObjectDefaultConverter1.OnTryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, T& value) at System.Text.Json.Serialization.JsonConverter1.TryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, T& value)
at System.Text.Json.Serialization.Converters.IEnumerableDefaultConverter2.OnTryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, TCollection& value) at System.Text.Json.Serialization.JsonConverter1.TryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, T& value)
at System.Text.Json.Serialization.JsonConverter1.ReadCore(Utf8JsonReader& reader, JsonSerializerOptions options, ReadStack& state) --- End of inner exception stack trace --- at System.Text.Json.ThrowHelper.ReThrowWithPath(ReadStack& state, Utf8JsonReader& reader, Exception ex) at System.Text.Json.Serialization.JsonConverter1.ReadCore(Utf8JsonReader& reader, JsonSerializerOptions options, ReadStack& state)
at System.Text.Json.JsonSerializer.ReadCore[TValue](JsonConverter jsonConverter, Utf8JsonReader& reader, JsonSerializerOptions options, ReadStack& state)
at System.Text.Json.JsonSerializer.ReadCore[TValue](Utf8JsonReader& reader, Type returnType, JsonSerializerOptions options)
at System.Text.Json.JsonSerializer.Deserialize[TValue](String json, Type returnType, JsonSerializerOptions options)
at System.Text.Json.JsonSerializer.Deserialize[TValue](String json, JsonSerializerOptions options)
at MatthiWare.FinancialModelingPrep.Core.Http.FinancialModelingPrepHttpClient.GetJsonAsync[T](String urlPattern, NameValueCollection pathParams, QueryStringBuilder queryString)

These properties can be null:
CompanyProfileResponse.Price
CompanyProfileResponse.Changes
HistoricalPriceItem.UnadjustedVolume

Can you please add these fixes? It seems FmP is using null values more and more?
Thank you

Hi,
I have a request, can the SearchAsync, SearchByTickerAsync, and SearchInternalAsync functions in de CompanyValuationProvider class be nullable?

Or do you mind if I make the change?

Implement symbol change endpoint: https://site.financialmodelingprep.com/developer/docs/symbol-change-api

Hi,

would be possible to add economic indicators?
Gdp, Cpi, Interest rates.. https://site.financialmodelingprep.com/developer/docs/#Economic-Indicator

Thank you

The type of TangibleAssetValueTTM is of type object while it should be long?.

FMP introduced a breaking change here while nothing is in the changelog about the property being removed.
sharesOutstanding property has been removed.

At the moment the field for totalDebt is not nullable.

Sometimes FMP API returns null for this field.

I created a support ticket to check if this is valid or not.

Hi, getting a deserialization ERROR when retrieving financial statements for many tickers, this was for ticker MTG.

ERROR when retrieving data for symbol: MTG message: System.Text.Json.JsonException: The JSON value could not be converted to System.Double. Path: $[0].interestIncome | LineNumber: 21 | BytePositionInLine: 26.
---> System.InvalidOperationException: Cannot get the value of a token type 'Null' as a number.
at System.Text.Json.Utf8JsonReader.TryGetDouble(Double& value)
at System.Text.Json.Utf8JsonReader.GetDouble()
at System.Text.Json.Serialization.Converters.DoubleConverter.ReadNumberWithCustomHandling(Utf8JsonReader& reader, JsonNumberHandling handling, JsonSerializerOptions options)
at System.Text.Json.Serialization.JsonConverter1.TryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, T& value) at System.Text.Json.Serialization.Metadata.JsonPropertyInfo1.ReadJsonAndSetMember(Object obj, ReadStack& state, Utf8JsonReader& reader)
at System.Text.Json.Serialization.Converters.ObjectDefaultConverter1.OnTryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, T& value) at System.Text.Json.Serialization.JsonConverter1.TryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, T& value)
at System.Text.Json.Serialization.JsonCollectionConverter2.OnTryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, TCollection& value) at System.Text.Json.Serialization.JsonConverter1.TryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, T& value)
at System.Text.Json.Serialization.JsonConverter`1.ReadCore(Utf8JsonReader& reader, JsonSerializerOptions options, ReadStack& state)

May I ask you to fix this serialization ERROR?
Thank you