iOS 16 transitions malfunctioning about swiftui-navigation-stack HOT 9 CLOSED

Hi team,
I think I found a fix on NavigationStackCompat.swift.

1. Line 27, I add @published on navigationType
   @Published private(set) var navigationType = NavigationType.push

2. Line 61, I set navigationType before the animation
   navigationType = .push
withAnimation(easing) {

3. Line 71, I set navigationType before the animation
   navigationType = .pop
withAnimation(easing) {

Let me know what you think.

Thanks

from swiftui-navigation-stack.

@matteopuc +1 I have also weird behavior with iOS 16

from swiftui-navigation-stack.

Hi, I am facing the same issue (on iOS 16 only). For what I can tell and tested it seems that the popped view animation is broken (it slides to right instead of left). Have you found a solution for this ?

from swiftui-navigation-stack.

I make my all animations opacity temporary as a workaround, but couldn't find a real solution yet

from swiftui-navigation-stack.

Setting transitionType to .none at least turns off the faulty animation. I tried to figure out what went wrong in the code but no luck.

NavigationStackView(transitionType: .none)

from swiftui-navigation-stack.

I tested this simple script, and it has the same issue with iOS16:
https://stackoverflow.com/questions/63782469/swiftui-how-to-have-next-and-back-animations/63782921#63782921

This thread might help:
Has the behavior of asymmetric transitions changed in SwiftUI 4 / iOS 16?
https://developer.apple.com/forums/thread/714977

from swiftui-navigation-stack.

@samjoly Your fix works for me. Will you create a pull request?

from swiftui-navigation-stack.

Hey hello @matteopuc & @samjoly,

Since no-one had encouraged to create the PR, I just created it from @samjoly comment. Please check if everything is fine and let's merge it in order to have it in the library 🙂

from swiftui-navigation-stack.

Thank you so much for your help guys, the bug is fixed! 🙏

from swiftui-navigation-stack.