mattclay / aws-terminator Goto Github PK

The Deployment Process section of the README.md is missing the instructions asking the user to install the mattclay.aws collection. The change was made via #72. The README.md should have been updated as part of that PR.

Ansible Pull Request: ansible/ansible#59925
The integration test failed with an AccessDeniedException in https://app.shippable.com/github/ansible/ansible/runs/149823/113/console
The integration test creates one CloudWatch log group and applies metric filters on it.

Cloudformation class currently returned stacks in a state of DELETE_COMPLETE, which live something approaching forever. Because the Cloudformation tests at one point used name=CloudformationInfo-IntegrationTest instead of resource_prefix, there's a deleted stack that's making the terminator unhappy. Double check the boto docs to make sure there's not a better way, otherwise see if we can filter by stack state. If that fails, cloudformation policies may need to act on arn:aws:cloudformation:us-east-1:{{ acct_id }}:stack/*

We're seeing ParameterNotFound in our Cloudwatch logs, for example on this CI run. It appears that everything should have worked here so need to reproduce and see if the Db is not updating the entry after the tests delete the Parameter or if something else is going on.
https://app.shippable.com/github/ansible-collections/community.aws/runs/847/35/console

"error \"ParameterNotFound\" terminating SsmParameter: name=/shippable-847-35/deeppath/toodir/samevar, id=/shippable-847-35/deeppath/toodir/samevar age=0:10:01, stale=True"

"Traceback (most recent call last):
  File \"/var/task/terminator/__init__.py\", line 138, in terminate
    instance.terminate()
  File \"/var/task/terminator/application_services.py\", line 323, in terminate
    self.client.delete_parameter(Name=self.id)
  File \"/opt/python/lib/python3.7/site-packages/botocore/client.py\", line 357, in _api_call
    return self._make_api_call(operation_name, kwargs)
  File \"/opt/python/lib/python3.7/site-packages/botocore/client.py\", line 661, in _make_api_call
    raise error_class(parsed_response, operation_name)
botocore.errorfactory.ParameterNotFound: An error occurred (ParameterNotFound) when calling the DeleteParameter operation:"

https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/ssm.html#SSM.Client.delete_parameter