The base58 from mattallty

base58's People

Contributors

Stargazers

Watchers

base58's Issues

Incorrect information in documentation

In the documentation you state

... Base-58 contains alphanumeric characters minus "1" (number 1) ...

However looking at the $alphabet value I see the number 1.

    static $alphabet = '123456789abcdefghijkmnopqrstuvwxyzABCDEFGHJKLMNPQRSTUVWXYZ';

encode/decode does not result in the same number in some cases.

>>> \Allty\Utils\Base58::encode(\Allty\Utils\Base58::decode('jrGwppJ4WSr'))
=> "jrGwppJ4XYr"

Here are some more examples for you:

https://gist.github.com/amcsi/0f9a14f6d9aec185e9e2a41d7f786b44

Wrong base

The script as it stands with the following:

static $alphabet = '23456789abcdefghijkmnopqrstuvwxyzABCDEFGHJKLMNPQRSTUVWXYZ';
const BASE = 58;

I ran a test of sequential numbers and here is what I found.

$i : encode($i) => decode(encode($i))

0 : => 0         // ERROR
1 : 3 => 1
2 : 4 => 2
3 : 5 => 3
4 : 6 => 4
.
.
.
57 : => 0 // ERROR
.
.
114 : 3Z => 114
115 : 3 => 1  // ERROR
116 : 42 => 116
.
.
172 : 4Z => 17
173 : 4 => 2  // ERROR
174 : 52 => 174

Here are my observations:
Changing to BASE 56 works but doing so will work but you could not encode 0 and Z would never be used

0 : => 0 // ERROR
1 : 3 => 1
2 : 4 => 2
.
.
54 : X => 54
55 : Y => 55  
56 : 32 => 56  // Z is never used
57 : 33 => 57
.
.
110 : 3X => 110
111 : 3Y => 111 // Z is never used
112 : 42 => 112
113 : 43 => 113

Im using simpletest to run these numbers

        while($i < 1000)
        {
            $this->assertEqual($i, Base58::decode(Base58::encode($i)));
            echo '<br>' . $i . ' : ' . Base58::encode($i) . ' => ' . Base58::decode(Base58::encode($i));
            $i++;
        }

Recommend Projects