matrix-org / matrix-hookshot Goto Github PK

Probably something like having a set of Provider classes.

The webhook handler could become a more generic inbound notification processor, which takes a set of notificationstreamproviders.

The GitHubBridge class could become a sort of generic router class which just applies formatting and routing to incoming notifications.

We currently have very little in the way of Matrix interactivity, but presumably that could also be part of the same routing.

The logs keep adding one of these lines with each new comment:

INFO 03:52:32:392 [GithubBridge] New connected added to !viChOTXZbGFChCWzqi:t2bot.io: GitHubIssue turt2live/test#35
INFO 03:52:32:393 [GithubBridge] New connected added to !viChOTXZbGFChCWzqi:t2bot.io: GitHubIssue turt2live/test#35
INFO 03:52:32:394 [GithubBridge] New connected added to !viChOTXZbGFChCWzqi:t2bot.io: GitHubIssue turt2live/test#35
INFO 03:52:32:396 [GithubBridge] New connected added to !viChOTXZbGFChCWzqi:t2bot.io: GitHubIssue turt2live/test#35

Mostly to avoid wasting cycles on registering users that are already registered

This is used for state tracking for the whole room, but certain counters should be in their own event.

I was already sitting in a #github_owner_repo_num:example.org portal when this happened:

E.g.

{
  "content": {
    "body": "📝 [Foo Project](undefined) for **[foo-org/Foo-Project](https://github.com/foo-org/Foo-Project)**",
    "format": "org.matrix.custom.html",
    "formatted_body": "<p>📝 <a href=\"undefined\">Foo Project</a> for <strong><a href=\"https://github.com/foo-org/Foo-Project\">foo-org/Foo-Project</a></strong></p>\n",
    "msgtype": "m.text"
  },
  "origin_server_ts": 1605724340009,
  "sender": "@github:half-shot.uk",
  "type": "m.room.message",
  "unsigned": {
    "age": 2095068
  },
  "event_id": "$wERG1gSpnp2iqXI9kTPPITfN5vDseZMwFAM8a5-UtKM",
  "room_id": "!YHwrCintmgybXLkyih:"
}

✔️ or ❌ or 💭 depending on the status of a review

So I can take holiday from work. Upon re-enabling, send a digest.

yaml vs yml: please be consistent

It'd be nice to show who authored a PR when it comes across in notifications, for context's sake.

Probably fairly important to help moderate the lands. We can wait until there is an actual API though

Until you restart the bot.

And perhaps rather than disabling user's feeds, we should detect 500s and increase the timeout for a bit. Maybe even warn the user that shit be broke (e.g. checking https://www.githubstatus.com/api/v2/status.json ).

I tend to not use emails for GitHub notifications because I tend not to use emails, and integrating notifications in my Matrix client would allow me to avoid switching apps regularly. Being able to specify a room for notifcations (optionally) would be quite cool, and probably easy to do.

it's not entirely clear what functionality would be lost, but it would be good to operate without a limitation like this. The oauth stuff is a github app that allows someone to send out a link, install the app, and off they go - all without an installation ID.

It seemed to work like this two years ago, but I can believe things have changed.

Could do with a screenshot of the form filled out or something. It's moderately unclear what all the URLs should be.

I suspect we create the room but then don't bind the connection properly, which is a bit of an epic fail.

ie: repo at a minimum

Probable conditions:

• Author of the issue
• Assigned to the issue

If it was "everything you've subscribed to" then the invite list could be overwhelming. The bridge should take care not to invite someone back if they've left, unless a condition changes (ie: assigned -> left room -> comment added should not re-invite, unless the user was re-assigned)

Probably by joining the repo room and asking the bot to subscribe them.

It's a bit scary to see that a random app has write access to the code

Its expensive

this is not so easy. They don't appear to have a webhook.

So issues can be created without having to join the portal room.

After reconfiguring the repos the app has access to you get redirected to the bridge which responds with:

Could not find user which authorised this request. Has it timed out?

When we handle incoming markdown from GitHub

This should be relatively easy