Code Monkey home page Code Monkey logo

zkevm-docs's Issues

Wrong reference to code

On the section "Read Operation And Main State Machine" of this page, there is a reference to code on the file main.pil lines 452 to 465.

This reference is no longer valid.

I think the new code its trying to refer to are lines 663 to 676 instead of lines 452 to 465.
So this extract instead of this one.

However, not only the lines of code have changed but also the content of these lines and the reference it's making reference to crValid, it's now r8Valid.

A constant column crValid is therefore created specifically for checking if a read is done at the last block. So, crValid...

So, current extract in the docs is the following:

hashK {
      addr,
      HASHPOS,
      DO,
      op0, op1, op2, op3,
      op4, op5, op6, op7
} in
      PaddingKK.crLatch∗PaddingKK.crValid {
      PaddingKK.addr,
      PaddingKK.len−PaddingKK.rem−PaddingKK.crLen+1,
      PaddingKK.crLen,
      PaddingKK.crVC0, PaddingKK.crVC1, PaddingKK.crVC2, PaddingKK.crVC3,
      PaddingKK.crVC4, PaddingKK.crVC5, PaddingKK.crVC6, PaddingKK.crVC7​
};

Lines (663 to 676) I believe it's trying to refer to instead are:

   hashK + hashK1 {
        addr,
        HASHPOS,
        D0 * hashK + hashK1,
        op0, op1, op2, op3,
        op4, op5, op6, op7
    } in
    PaddingKK.crLatch * PaddingKK.r8valid {
        PaddingKK.addr,
        PaddingKK.len - PaddingKK.rem - PaddingKK.crLen + 1,
        PaddingKK.crLen,
        PaddingKK.crV0C, PaddingKK.crV1C, PaddingKK.crV2C, PaddingKK.crV3C,
        PaddingKK.crV4C, PaddingKK.crV5C, PaddingKK.crV6C, PaddingKK.crV7C
    };

And current lines it's currently referring to (lines 452 to 465 which seems wrong):

                  2**0  * arithEq0      + 2**1  * arithEq1      + 2**2  * arithEq2      + 2**3  * assert
                + 2**4  * bin           + 2**5  * hashK         + 2**6  * hashKDigest   + 2**7  * hashKLen
                + 2**8  * hashP         + 2**9  * hashPDigest   + 2**10 * hashPLen      + 2**11 * ind
                + 2**12 * indRR         + 2**13 * isMem         + 2**14 * isStack       + 2**15 * JMP
                + 2**16 * JMPC          + 2**17 * JMPN          + 2**18 * memAlignRD    + 2**19 * memAlignWR
                + 2**20 * memAlignWR8   + 2**21 * mOp           + 2**22 * mWR           + 2**23 * repeat
                + 2**24 * setA          + 2**25 * setB          + 2**26 * setC          + 2**27 * setCTX
                + 2**28 * setD          + 2**29 * setE          + 2**30 * setGAS        + 2**31 * setHASHPOS
                + 2**32 * setPC         + 2**33 * setRCX        + 2**34 * setRR         + 2**35 * setSP
                + 2**36 * setSR         + 2**37 * sRD           + 2**38 * sWR           + 2**39 * useCTX
                + 2**40 * useJmpAddr    + 2**41 * JMPZ          + 2**42 * call          + 2**43 * return
                + 2**44 * hashK1        + 2**45 * hashP1        + 2**46 * useElseAddr;

    (1 - arithEq0) * arithEq0 = 0;

I can summit a PR with the change but wanted to confirm my assumptions are correct.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.