mathspy / gatsby-storybook-jest-starter Goto Github PK

looks like a great starter. i found you from this tweet. i'll definitely dive deeper when i start my next gatsby site.

one thing i've found useful in my storybook instances, including those i've done for gatsby, is storybook-router. it lets you define links between stories that work with react-router's link and therefore (at least until today) gatsby-link. i thought it could be a useful addition to your starter to further highlight the value of a storybook instance.

i've already opened an issue about @reach/router support. since react-router and vue-router are both already supported, i imagine there is a good chance that we will see this get added as well.

Your starter is really useful, but my concern is: how to use Storybook v5 with gatsby +scss + css modules

actually i was unable to make it possible

do you have any plan to upgrade from v3 to v5?

It looks like Storybook isn't using the .babelrc defined in the project root. I think you are defining a different set of babel plugins inside storybook/webpack.config.

Wouldn't it make more sense to parse babelrc and use the plugins defined there?

My usecase is that I'm using styled-components and babel-plugin-styled-components which automatically generates a display name for components based on either the variable or file name. I have this defined in the project's .babelrc, however this isn't being used for components within storybook, meaning if I want to display their source within storybook it looks like: <styled.div> instead of <VLayout>.

Firstly, thanks for this. Hopefully Gatsby will fully embrace storybook and make the integration significantly easier, but in the mean time this is really helpful.

Thought you might consider adding visual regression testing via: jest-image-snapshot

Thanks for posting this starter. When running storybook http://localhost:6006/ I get error for header and layout.stories.js and header.stories.js

I'm getting error :

__PATH_PREFIX__ is not defined
            ReferenceError: __PATH_PREFIX__ is not defined

Any idea why this might be happening ?

Update both storybook documentations and testing documentations to reflect new switch to @Reach/Router

gatsby-storybook-jest-stater should be gatsby-storybook-jest-starter

the r in starter is missing 😄