mathiaspius / hrobot-rs Goto Github PK

These types should be easily constructible from u32 integers.

Should make the API much more intuitive since a function taking a TemplateId lets you search the docs for references to it and thereby ways of acquiring one/constructing

Automatically makes impossible errors like trying to fetch a server using a firewall template ID for instance, except when explicitly constructing a TemplateId using a server_number Id.

Hetzner is updating their dedicated server billing model from monthly to hourly.

https://docs.hetzner.com/general/others/new-billing-model/

With that change, it might be feasible to redesign the disruptive tests to use short-term rented dedicated servers instead of risking my existing server fleet. Integration tests could also be run as part of the pipeline flow without incurring huge debts.

Might be useful for people to be able to store returned objects directly in json format.

Places where byte sizes should be used:

• Traffic Warnings are implicitly in MB, should be coerced into ByteSize.
• Traffic limits are strings "5 TB" instead of Option<ByteSize> where None implies unlimited.

I just noticed that I've been relying solely on the AsyncRobot::default() functionality which uses AsyncRobot::from_env() under the hood for fetching username and password.

There is an AsyncRobot::new() constructor which takes username and password, but it also requires passing in a hyper client which is very cumbersome to construct.

It would be nice to have a simple AsyncRobot::from_credentials(username: &str, password: &str) constructor which handles the heavy client construction.

I have a dedicated server without an IPv4 Address, so only IPv6 subnet, and in the response of e.g. get_server or list_servers, the ip field is null, which means serde can't deserialize the response.

It looks like this is undocumented behavior, at least the Robot API docs have no example for this.

The relevant piece of code:

This could be fixed by either wrapping the Vec in an Option (I tried that locally, would be a breaking change), or using a custom deserialization function.