mathiasbynens / array.of Goto Github PK

Could you provide make this library (and other useful libraries that you create) unobtrusive? I can't reuse it at either library or application level since it overrides native stuff.

Thanks for reviewing my pull requests and merging them. I was wondering when a new release to NPMJS' registry would be published, it isn't an urgent issue, please don't feel rushed with it :-)

It seems that some other bugs have been fixed which have not been released, here is the difference since the last release - I believe the only release that has been made is from the project's initial commit.

Array#slice with NodeLists errors in IE < 9. So, we should avoid Array#slice. +@jdalton

• isConstructor should not execute the constructor function, but that can't be fixed without ES6 Proxies. 😞
• Missing Put(result, "length") before return result. Also requires "use strict" directive for proper semantics. Test case:

Array.of.call(Object).length === 0;
Array.of.call(function(){ return Object.freeze({}); }); // should throw

• This line actually needs to use Object.defineProperty() to avoid executing setters. Test case:

Object.defineProperty(Array.prototype, "0", {
    set: function(x) { throw "set:" + x }
});
Array.of("abc"); // should not throw

Since it’s impossible for new C() to return a falsy value in JavaScript, we can simplify isConstructor and the surrounding code into something like useConstructor(C, len) || Array(len).