mateusrodcosta / share2storage Goto Github PK

For 1.0.0 I would like to have a monochrome icon available.

I do have the asset available but I need to be able to properly "cut out" some parts to use it.

There are some apps which don't allow sharing and saving but have an option to open a file with another app. It would be really handy if this app could accept such intents and save the files.

https://gitlab.com/fdroid/rfp/-/issues/2321

eg. have "Save in default" or "Save in last (/last path/)" and "Save" (this one lets you choose, like now)

https://gitlab.com/fdroid/fdroiddata/-/jobs/5916419780#L2102

/LE: fyi https://gitlab.com/fdroid/fdroiddata/-/commit/f83b3f21376174bc71fe34c9a637d3fc5453cc39

takePersistableUriPermission can take a combination of the flags Intent.FLAG_GRANT_READ_URI_PERMISSION and Intent.FLAG_GRANT_WRITE_URI_PERMISSION.

Currently both are used for Save Locally when setting a Default save location folder. Since we only need to write to the folder and there's no need at all to read, consider switching to only use Intent.FLAG_GRANT_WRITE_URI_PERMISSION.

This change should also not break the Default save location setting UI when upgrading (this might happen when changing folders if not done properly).

Since the app won't even ask for essential permissions like storage access or media access, it's no wonder that the app won't show up in the share menu.
Please fix it, I like the concept of this app.

Additionally, I'm not able to manually grant these permissions, because the app won't show up in the permission menu of Android's settings.

Nvm, it DOES work, but just for local files. I'm confused now- why would you want to save your local files locally? This doesn't make any sense to me.
What I actually tried was to export a PDF file given out by another app to my local storage, as the original PDF could only be shared, not saved.
Doesn't Share2Storage support this task? And if not, why not? This would be the only case I needed an app like this one.

When I zip a file and share it and try to save it using this app, and it's about 500MB or more, then it never works. This is true for version 1.2.1, but I haven't tried the most recent version.

Feature Request / Enhancement
Some Android tools and applets seem only to support a Share Nearby sharing option.
Is it possible to have Share2Storage behave like a "nearby" device too?

Currently the app only supports a single file, so it isn't shown on the share sheet when sharing multiple files.

Add support for the intent filter for multiple files as well as UI support for showing info and downloading multiple files.

Some apps force opening files with ACTION_VIEW, and do not give you an option to save the file.

It would be nice if it was possible to handle this action as well.

Thanks!

When saving to storage, in the app menu, there should be a image preview that could also be maximized and zoomed

App v. : 1.1.0

FATAL EXCEPTION: main
Process: com.mateusrodcosta.apps.share2storage, PID: 31971
java.lang.RuntimeException: Unable to start activity ComponentInfo{com.mateusrodcosta.apps.share2storage/com.mateusrodcosta.apps.share2storage.DetailsActivity}: java.io.IOException: broken file descriptor
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3983)
at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:4136)
at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:103)
at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:149)
at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:99)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2581)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loopOnce(Looper.java:224)
at android.os.Looper.loop(Looper.java:318)
at android.app.ActivityThread.main(ActivityThread.java:8720)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:561)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1013)
Caused by: java.io.IOException: broken file descriptor
at android.graphics.BitmapFactory.nativeDecodeFileDescriptor(Native Method)
at android.graphics.BitmapFactory.decodeFileDescriptor(BitmapFactory.java:861)
at android.graphics.BitmapFactory.decodeFileDescriptor(BitmapFactory.java:895)
at com.mateusrodcosta.apps.share2storage.DetailsActivity.onCreate(Unknown Source:206)
at android.app.Activity.performCreate(Activity.java:8891)
at android.app.Activity.performCreate(Activity.java:8856)
at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1468)
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3965)
... 12 more

When clicking on the file name, it should be possible to edit the file name

Current the main theme is defined as

    <style name="Theme.App" parent="@android:style/Theme.Material.Light.NoActionBar">

Consider using the equivalent AppCompat theme in a future version.

The following parameters are defined to be able to have white icons, confirm later:

        <item name="android:navigationBarColor">@android:color/transparent</item>
        <item name="android:statusBarColor">@android:color/transparent</item>
        <item name="android:windowLightStatusBar">false</item>

And this is the code to manually enable EdgeToEdge while supporting the white icons:

        WindowCompat.setDecorFitsSystemWindows(window, false)
        val windowInsetsController = WindowCompat.getInsetsController(window, window.decorView)
        windowInsetsController.isAppearanceLightNavigationBars = true

Check all these details for a next version