mateimarica / old-genius Goto Github PK

I like this approach that does not need to reload the page each time, but, unfortunately, it does not always work. I didn't find any patterns when it doesn't. Closing and reopening Firefox might be enough to make it not work, unless turned off and on again.

See here: https://github.com/mateimarica/old-genius/blob/main/src/background/background_chromium.mjs#L21

The onInstalled listener is called if the extension receives an auto-update. That means this block of code

// Refresh rule
chrome.declarativeNetRequest.updateDynamicRules({
  removeRuleIds: [id],
  addRules: [rule]
});

always add the redirect rule regardless of whether enabled is true or false.

Solution: check that enabled is true before calling that block of code. Do this for both chromium and firefox background scripts.

Better solution: move the whole block of code into the if (details.reason === chrome.runtime.OnInstalledReason.INSTALL) { block, refreshing the rule on every update is probably useless.