Comments (3)
I'm sorry, but as seen from the server you can't ask for 2 uploads to have the same X-Progress-ID at the exact same time, hence I prefer to return an error (even though the upload would succeed).
You probably can generate X-Progress-ID that have a very low probability of collision (ie a MD5 or SHA sum of some random information).
You can modify the upload-progress module to return NGX_DECLINED instead of NGX_HTTP_INTERNAL_SERVER_ERROR when duplicate X-Progress-ID are found, that will accomplish what you want.
But I don't think it should be part of the "official" distribution. I might accept a patch providing an option that would change this behavior (as long as the default is to error), though.
from nginx-upload-progress-module.
First, thank you for your answer.
Actually we have noticed that browser can do nasty things, such as
automatically replay the post action immediatly after a network
failure (for example), in this case, I want to consider the last post
as "correct" action...
I'm going to play with the NGX_DECLINED instead of
NGX_HTTP_INTERNAL_SERVER_ERROR...
If I consider my code a quite "smart", I will suggest you the patch :)
Thanks!
Erwan
2012/5/11 Brice Figureau
[email protected]:
I'm sorry, but as seen from the server you can't ask for 2 uploads to have the same X-Progress-ID at the exact same time, hence I prefer to return an error (even though the upload would succeed).
You probably can generate X-Progress-ID that have a very low probability of collision (ie a MD5 or SHA sum of some random information).
You can modify the upload-progress module to return NGX_DECLINED instead of NGX_HTTP_INTERNAL_SERVER_ERROR when duplicate X-Progress-ID are found, that will accomplish what you want.
But I don't think it should be part of the "official" distribution. I might accept a patch providing an option that would change this behavior (as long as the default is to error), though.
Reply to this email directly or view it on GitHub:
#24 (comment)
from nginx-upload-progress-module.
Hello,
Here is a small patch to give the possibility to ignore a tracking id already register.
It enable a new configuration setting flag "upload_progress_noerror_if_exist".
If set to "on", don't raise error when the same tracking id is found
If set to "off", default behavior, raise an INTERNAL_SERVER_ERROR.
Default value is "off".
I will be happy if you enable this feature in future release :)
I'm not familiar with gitub, there is probably a better way to transmit a patch, but here is a gist of the patch...
https://gist.github.com/2694514
Regards.
from nginx-upload-progress-module.
Related Issues (20)
- Didn't work with chrome version 31.ole chrome is ok. HOT 3
- NginxHttpUploadProgressModule received and size are the same HOT 12
- When TLS is enabled recieved and size are always the same HOT 4
- Wrong fix HOT 2
- cannot set tracking id
- Module seems to work correctly with uwsgi_pass
- Received bytes begins at complete file size for a few ticks and then functions as normal
- Progressbar with "vkholodkov/nginx-upload-module" return completed upload when starting
- Received and size are the same HOT 1
- Received and size are the same when using HTTP/2 HOT 2
- Dynamic module support HOT 6
- nginx-upload-progress-module appears to be not loaded HOT 2
- Received and size are the same HOT 8
- not work for proxy_pass to other nginx HOT 1
- Problem with 'dynamically loadable module' support. HOT 3
- Implement HTTP Server-Sent Events HOT 1
- nginx-upload-progress don't work in nginx 1.10.2
- Received and size are the same HOT 1
- Compilation fails with Nginx 1.23 HOT 10
- The Linux system is Alpine Linux, and the Nginx version is 1.25. Currently, the compilation is failing.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nginx-upload-progress-module.