Code Monkey home page Code Monkey logo

Comments (3)

Whissi avatar Whissi commented on August 15, 2024

https://trac.nginx.org/nginx/ticket/1115

from nginx-upload-progress-module.

masterzen avatar masterzen commented on August 15, 2024

@Whissi thanks for pointing me to the Nginx documentation bug.

So if I understand correctly, this can be fixed with this modification:

if [ $ngx_module_link = DYNAMIC ] ; then
    ngx_module_type=FILTER
    ngx_module_name=ngx_http_uploadprogress_module
    ngx_module_srcs="$ngx_addon_dir/ngx_http_uploadprogress_module.c"
    . auto/module
elif [ $ngx_module_link = ADDON ] ; then
    ngx_module_type=CORE
    ngx_module_name=ngx_http_uploadprogress_module
    ngx_module_srcs="$ngx_addon_dir/ngx_http_uploadprogress_module.c"
    . auto/module
    ngx_module_type=FILTER
    ngx_module_name=ngx_http_uploadprogress_module
    ngx_module_srcs="$ngx_addon_dir/ngx_http_uploadprogress_module.c"
    . auto/module
fi

@migmedia I won't have the time to test before a couple of days, can you try for me and report success/failure?

from nginx-upload-progress-module.

Whissi avatar Whissi commented on August 15, 2024

I am currently preparing a fix for Gentoo. My PR will look different:

diff --git a/config b/config
index 364af8c..d704460 100644
--- a/config
+++ b/config
@@ -1,5 +1,5 @@
 ngx_addon_name=ngx_http_uploadprogress_module
-if test -n "$ngx_module_link"; then
+if [ $ngx_module_link = DYNAMIC ] ; then
     ngx_module_type=FILTER
     ngx_module_name=ngx_http_uploadprogress_module
     ngx_module_srcs="$ngx_addon_dir/ngx_http_uploadprogress_module.c"

...as I don't see that your module has a CORE module.

from nginx-upload-progress-module.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.