masonzhang / sketchsolve Goto Github PK

Hello

Your project is very interesting.  Thanks

Solve.cpp
510:   delete origSolution; 

530:   *x[i]=origSolution[i]; 

It seems to cause no harm but origSolution is referenced after deleted.

Hi,

Apologies in advance for posting this here, couldn't find another way to
send the project owner a note. Could you shoot me an e-mail at
[email protected]? I want to do geometric constraint solving in C#.

Thanks!

Wout

Solve.cpp  following variables are alloced but not deleted.

deltaX;
gamma;
gradnew;

Solve.cpp  552-567  calc.c
 The following line, the calculated error can be negative, 
 I think that the error should be always positive.

      if(cons[i].type==P2PDistance) 
         { 
                 error+= (P1_x - P2_x) * (P1_x - P2_x) + (P1_y - P2_y) * 
(P1_y - P2_y) - distance * distance; 

         } 

         if(cons[i].type==P2PDistanceVert) 
         { 
                 error+= (P1_y - P2_y) * (P1_y - P2_y) - distance * 
distance; 
         } 

         if(cons[i].type==P2PDistanceHorz) 
         { 
                 error+= (P1_x - P2_x) * (P1_x - P2_x) - distance * 
distance; 
         } 

 should be 

     if(cons[i].type==P2PDistance) 
         { 
       temp = _hypot(P1_x - P2_x,P1_y - P2_y) - distance;
           error += temp*temp;
         } 

         if(cons[i].type==P2PDistanceVert) 
         { 
        temp = fabs(P1_y - P2_y) - distance;
        error += temp*temp;
         } 

         if(cons[i].type==P2PDistanceHorz) 
         { 
        temp = fabs(P1_x - P2_x) - distance;
        error += temp*temp;
         }