Code Monkey home page Code Monkey logo

notify's People

Contributors

adlane avatar giorger avatar mashlol avatar michaelkebe avatar michelbahl avatar mikafouenski avatar mlesniew avatar otanim avatar ptdev avatar szpeter80 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

notify's Issues

'Successfully sent notification' but no notification received

after running
./sh/notify.sh -t "My message"
(after I registered with the key the android app generated of course)
the shell script prints this every time:
[notify] Successfully sent notification.
but no notification received on the android device.

I tried reinstalling the app, as a previous issue stated that helped him for a similar situation, but it did not solve the issue I am experiencing.

Reading notification

The application should return the message (if any) and other information instead of the default view.
screenshot_2015-12-05-11-02-48

API not working

I'm tryed to use node.js linux client and using API with this command https://appnotify.herokuapp.com/notify?text=blaaa&title=bla&to=iAD4BIZbrL but got response

{"success":false,"error":"Invalid "to" param specified."}

Vibration when notification is received not always working

I just discovered this app and I find it very useful, but I also noticed a small problem. The phone vibrates on received notifications only if the app is open and the phone is not locked. If either the app is not open or even if the app is open but the phone is locked, the phone will not vibrate on received notifications.
I'm not sure if this was intended to work like this, but would there be a way to make the phone vibrate on received notifications even if it is locked or the app is not open?

wrong example

The readme says cmd || notify will fire the notification whether or not the command succeeds, but actually it only fires if the command returns 1 (which by convention means failure).

$ true || echo notify
$ false || echo notify
notify
$

Execution from crontab

Hi, sorry if Im opening an issue for something is probably my lack of linux understanding...
Im trying to use notify to send me a script's result using cron.
Im able to execute notify from command line, but if I execute it from crontab, is not working:

I tried like this:
crontab content:

19 08 * * * /home/solifugo/notify_test.sh
22 08 * * * /usr/local/bin/notify -t "test2"

none of them are working executed by cron, but they are both fine if I do it from command line.

raspi: cat /home/solifugo/notify_test.sh
#!/bin/bash
/usr/local/bin/notify -t "test"
raspi:

I read something about Node script execution, but not sure if that applies here.

Anyway, hope someone can guide me.

Btw, the app is very nice. Simple and exactly what I really need (once I get crontab script working.. :P )

Bug of "minus" character

Hi,

There's a bug with the handling of minus sign if the text is starting with it. No matter if the string to send is inside '' or "".

notify -V
0.1.5

Examples:
notify --text '--blah'
error: unknown option `--blah'

notify --text "--blah"
error: unknown option `--blah'

notify --text -blah
Usage: notify [options]
[...]

notify --text "blah"
[notify] Notifying [....]

notify --text "-blah"
Usage: notify [options]
[...]

Br,
B.

Shell script fails on MacOS (Unexpected Positional Arguments)

On MacOS 10.14.3, using this file, running notify.sh with or without any arguments returns Unexpected positional arguments.

When I add echo $# after line 56:

if [ "$#" -ne 0 ]
then
    echo "Unexpected positional arguments."
    echo $#
    exit 1
fi

It returns 6 when running without any positional arguments. It returns 8 when two positional arguments are used.

I know this script isn't intended to run on MacOS, but this seems like it's probably some tiny syntax difference that I'm not understanding.

Key is "hello world" and no notification audio

The first time I installed it, all it said was "your key is 'hello world'." (A review on Google Play reported the same problem). I tried opening and closing it several times to no avail.

After removing and installing it again, it works, and notifications are sent. However, they don't always arrive (even when it says they have), and no sound is played for notifications. Sometimes it vibrates.

Are you able to reproduce these issues?

Desktop application

Would be nice if there were an agent for the desktop as well. Figured I would open a ticket to track that request. Thanks

-John

Change key storage format

Issues/Features #36, #31, #35 all hinge on the storage schema of the keys. I am not sure if the current schema would work best with the previously mentioned features.

I like YAML. It is human readable and allows for simple access implementation. It would require an additional module. Also if in the future one wanted to create a 'group' to notify then YAML would facilitate this nicely (see here).

Here is the yaml schema that I propose:

keys:
  asdf: android
  qwer: null
aliases:
  android: asdf

Separating keys and aliases simplifies CRUD operations.

Release a new version to play store

I wanted to add longer notifications in the android app, but it was already done.

The version in the play store is an old one.

What about releasing a new version to the play store?

Config file for .notifyreg location

Most CLI's that store data files have the option to specify where they would like the file to be stored. Right now it is hard coded. I was thinking of .notifyconfig file:

{
  "regFilePath" : "~/.notifyreg"
}

It would also help with testing (#38 ). I was using mock-js to create a mock filesystem for the tests but that creates intermitten issues. With a config file I could change the file before executing tests.

Add option to notify individual keys

notify -k asdf -t "Message" -i "Title"

notify --only-key asdf --text "Text" --title "title"

Created separate issue to discuss the implementation separately.

Work behind a proxy

Hello,
I have just installed and I wanted to know if it works behind a proxy. npm worked correctly. When I run any command or just trigger notify it hangs and nothing happens, no message etc.

Unit tests? (Just for fun)

I realize this project is small but I haven't ever implemented JS unit tests before so I thought this could be a good opportunity to practice. If you are alright with it, I would create a tests/ folder and implement unit tests on some of the logic using Mocha or Jest.

Set notification's title using CLI

notify function accepts text and title, but the CLI only sends the text to the function. It would be great to set the title using the CLI:

$ notify --text "Cool message" --title "Awesome title"

Channel Name

Hey man, really cool project. I've registered my device and get

[notify] Your registration code has been saved to ~/.notifyreg

However, when testing this I run

ls -l ; notify

and get the following error:

[notify] Encountered an error: { code: 141, message: 'Error 112: Channel name must start with a letter: '}

I won't submit my identifier here but it does start with a 2. Is this causing an issue? Can I re-create a key?

Thanks man.

Notify not working anymore

Hello,
is notify really not working anymore? If yes, is there a successor or simple alternative?
It worked perfectly until a few weeks ago.
Thank you

Add option to map keys to a name

It would be nice to have the ability to name the keys and notify based on specific names. For example:

notify -n -t "<name>" "<some cool message>"

I could help implement if need be, just let me know.

SyntaxError: Unexpected token

When registering the key, an error occurs. The notify was installed from "npm install -g notify-cli"

$ notify -r g5Y2221
/usr/local/lib/node_modules/notify-cli/notify.js:9
  var keys = Utils.getRegFile().split(/\n+/).filter(key => key);
                                                         ^
SyntaxError: Unexpected token >
    at Module._compile (module.js:439:25)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
    at Object.<anonymous> (/usr/local/lib/node_modules/notify-cli/app.js:8:14)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)

Heads-up notification

Hello,
thanks for this app! It is very useful and I can finally get the notifications I need directly on the phone, without needing to use chat applications such as Telegram or Slack.

I would like to suggest, if possible, to introduce heads-up notifications when requested, because I think that just having the badge in the notification area is not very visible right now and if a notification happens while I am watching the phone I will not notice it immediately.

Thanks again!

/bin/sh on Ubuntu does not understand the [[ foo ]] notation

When the script is executed, it outputs: "./notify.sh: 3: ./notify.sh: [[: not found"
Changing the shebang line to

#!/bin/bash

resolves this problem. On Ubuntu and possibly also on Debian, the default shell is "dash" which had caused some headache not a long time ago for me when debugging shell script behaviour.

hope this helps

regards,

Peter

Nothing Happens

I've installed the cli but after registering the device and sending a notification nothing happens. I get no notification and in both cases the cli just exits silently.

Not getting push notification on android

Tried running this command:
echo "test" ; notify

which produced this:

test
[notify] Successfully sent notification.

But no notification on my android. Is there any logs where I can try to find the issue?

Custom text

Would be nice if you could send your own text along with a notification

Spare communication channel for local Fire Department

Hi

I would like to use Notify to inform a group of firefighters (15 persons) about alarm in our unit.
It will be use as a spare comms channel.
How I can inform a group of person instead of only on?

regards
Lukasz

Multiple devices

I use multiple devices. So I would like to send one message to my phone & tablet.
Is it possible to edit the .notifyreg file for more than one device?

Like this:
token123
token321

Thanks

Not sending notifications

When I type notify it says that it has sent a notification but no notification appears. This also occurs with the shell script.

I have:
Android: Nexus 5X 7.1.1 (W/ companion app installed)
Laptop: Arch Linux 4.10.6-1

I also tried clearing the Android app data and re-registering but that did not work either.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.