marwan116 / raycraft Goto Github PK

Create the app on the fly on run

Currently, we perform the following:

    def init(self, func) -> None:
        self._initializers[func.__name__] = func

        def constructor(obj):
            for (
                initializer_name,
                initializer,
            ) in self._initializers.items():
                setattr(obj, initializer_name, initializer())

Current implementation assumes that all initiliazer functions don't accept any arguments

Fix it so that it accepts arguments and those argument values can be passed to RayCraftAPI.__call__

Current implementation is constrained to post, and only accepts path argument

    def post(self, path: str) -> Any:
        def decorator(func):
            self._http_methods[func.__name__] = {
                "path": path,
                "func": func,
            }

        return decorator

Instead, we should delegate fully to the fastapi method and store all arguments in the _http_methods dict

current __init__ signature is

class RayCraftAPI:
    """RayCraftAPI class."""
    def __init__(self, **serve_deployment_kwargs):

Instead it should include both ray serve and fastapi kwargs - and ideally should have them spelled out for a friendlier interface.