Would be good to write some tests for some advanced features of forms:

• showing errors with fields
• model binding
• getting old value

http://blog.getbootstrap.com/2017/12/28/bootstrap-4-beta-3/

{{ bs()->formGroup()->label('Is 1=1?') ->control( bs()->radioGroup('smaller_sizes', [ 'Y' => 'Yes', 'N' => 'No' ]) ) }}

If the form errors, both radios are marked as 'checked'. Fixed in #41

Is the CustomFile element "requireable" (required="required")?

This code sets the required="required" attribute on the control div and not on the input element:

{!! bs()->formGroup()->control(
   bs()->file('document', 'Please select..')->attributes(['required' => 'required'])
)->label('Document') !!}

As title, I think it's good to use GitHub Action to be the CI service.

I can do for that once the repository owner accepts that :).

They should only have the class invalid-feedback

See: twbs/bootstrap#23454

Will be cool to have an opportunity to bind model data to form, for update record.

Hey, are there any plans making this package Laravel 6 compatible?

Hey! Maybe I do something wrong, but when I add 'files' => true to options array for form, nothing happens... I saw sources, no code for this option. Need to add it.

small / large / full width

https://getbootstrap.com/docs/4.0/components/buttons/#sizes

Declaration of MarvinLabs\Html\Bootstrap\Elements\Traits\Disablable::disabled() should be compatible with Spatie\Html\Elements\Input::disabled($disabled = true)

https://getbootstrap.com/docs/4.0/components/forms/#checkboxes-and-radios

See https://getbootstrap.com/docs/4.0/components/progress/

bs::alert component does not work as intended, you can try the first simple example in the documentation.

Below is stack trace:

Undefined variable: class (View: /foo/bar/vendor/marvinlabs/laravel-html-bootstrap-4/resources/views/alert.blade.php) (View: /foo/bar/vendor/marvinlabs/laravel-html-bootstrap-4/resources/views/alert.blade.php) (View: /foo/bar/vendor/marvinlabs/laravel-html-bootstrap-4/resources/views/alert.blade.php)

Environment

• Laravel 5.8
• laravel-html-bootstrap-4 1.6

Thanks for adding the radio and radioGroup elements!

In the RadioGroup __call method are some methods that will be forwarded to the Radio elements, butdisabled is not one of them:

['radio' => '', 'forgetRadio' => 'forget', 'addRadio' => 'add']

There is some magic in the __call method I did not understand, but it not seems a matter of adding disabled (and 'readonly') to the array.

Could you add multi-select support to a future release?
I can ->attribute('multiple') on a select, but I can't pass an array as the values.
Thanks 💯

Hi, when using the checkBox() method, I'm unable to change the checkbox id and leave the name different, eg. input name = permissions, id of input: permission-1;

Here is the code I've tried

@forelse($permissionsChunk as $permission)
    {!! bs()->checkBox()->id("permission-{$permission->id}")
->name('permissions[]')->description($permission->description) !!}
@empty
@endforelse

But id stays the same as input name. I think the problem is in this line (219):

Can you look into it please? Or am I doing something wrong? Thanks.

Checkboxes with the name representing an array of options generates checkboxes with the same id

Example from: https://github.com/marvinlabs/laravel-html-bootstrap-4/blob/master/docs/checkbox.md#checkboxes-with-name-representing-an-array-of-options

{{ bs()->checkbox('hobbies[]')->id('hobby_ski')->description('Skiing') }}
{{ bs()->checkbox('hobbies[]')->id('hobby_surf')->description('Surfing') }}
{{ bs()->checkbox('hobbies[]')->id('hobby_dive')->description('Diving') }}

Generated HTML:

<div class="custom-control custom-checkbox" id="hobby_ski">
    <input class="custom-control-input" type="checkbox" name="hobbies[]" value="1" id="hobbies">
    <label class="custom-control-label" for="hobbies">Skiing</label>
</div>
<div class="custom-control custom-checkbox" id="hobby_surf">
    <input class="custom-control-input" type="checkbox" name="hobbies[]" value="1" id="hobbies">
    <label class="custom-control-label" for="hobbies">Surfing</label>
</div>
<div class="custom-control custom-checkbox" id="hobby_dive">
    <input class="custom-control-input" type="checkbox" name="hobbies[]" value="1" id="hobbies">
    <label class="custom-control-label" for="hobbies">Diving</label>
</div>

All ids in of the three checkboxes are "hobbies". The id should be set on the control object, not on the wrapper.

When opening a form we have no way to add attributes to the generated tag.

Maybe via the options, or with a 4th parameter to the openForm function.

Add the shortcut methods to our own interface in order to use our own A class (with btn and all)

->checked($this->getFieldValue($this->name, $this->selectedOption === $radio->getValue()))

This wont work :

$options = array [1,2,3];
$checked = "1";

Ofcourse $checked could be casted to int, but for this situation using === is way to strict and == should be used.

They do not render properly + should be able to handle the lang attribute

https://getbootstrap.com/docs/4.0/components/forms/#file-browser

When using bs()->textarea()

Symfony \ Component \ Debug \ Exception \ FatalErrorException (E_UNKNOWN)
Class 'Spatie\Html\Elements\TextArea' not found

Error on /vendor/marvinlabs/laravel-html-bootstrap-4/src/Bootstrap/Elements/TextArea.php:17

Spatie deinfe the class as Textarea, not cap on first A

When control is wrapped inside a form group.

This one seems to have appeared recently (I'm using 1.6.4):

{{ bs()->radioGroup('agree_terms_1', [
                                      'y' => 'I am interested!',
                                      'n' => 'No, thanks.',
                                    ], 'y') }}

I can't select anything other than the first radio. Upon closer inspection each radio button has the same ID:

<div class="radio-group" id="agree_terms_1_radio_group">
<div class="custom-control custom-radio">
    <input class="custom-control-input" type="radio" checked="checked" name="agree_terms_1" value="y" id="agree_terms_1">
    <label class="custom-control-label" for="agree_terms_1">I am interested!</label>
</div>

<div class="custom-control custom-radio">
    <input class="custom-control-input" type="radio" name="agree_terms_1" value="n" id="agree_terms_1">
    <label class="custom-control-label" for="agree_terms_1">No, thanks.</label>
</div>
</div>

Example:

{{ bs()->text('profile[first_name]', $user->first_name) }}

If you submit a form containing the above, and there is a validation error, the value previously inputted into the form is not loaded back into the field.

Caused by ln 31 of OldFormInputProvider.php.
return $this->request->old(field_name_to_id($key), $default);

field_name_to_id($key) translates to "profile_first_name", wheras it should be "profile.first_name".

Changing the line to simply return $this->request->old($key, $default);, solves the issue.

https://getbootstrap.com/docs/4.0/components/dropdowns/

https://getbootstrap.com/docs/4.0/components/card/

As an effort to simplify creation of horizontal forms (related to #12, #14)

For instance

    {{ bs()->formGroup(bs()->text('first_name', 'John'))
            ->wrapControlIn(bs()->div()->addClass('col-sm-10'))
            ->label('First name', false, ['col-sm-2'])
            ->addClass('row')}}

could be

    {{ bs()->formGroup(bs()->text('first_name', 'John'))
            ->label('First name', false)
            ->asRow(['sm' => [2, 10]]) }}

or with offsets in some cases :

    {{ bs()->formGroup(bs()->submit('Submit', 'secondary')->child(fa()->icon('send')->addClass('ml-2')))
            ->wrapControlIn(bs()->div()->addClass('col-sm-10 offset-sm-2'))
            ->addClass('row')}}

would be

    {{ bs()->formGroup(bs()->submit('Submit', 'secondary')->child(fa()->icon('send')->addClass('ml-2')))
            ->asRow(['sm' => [2, 10]]) }}

Maybe an API would be better to simplify building row classes:

->asRow(['sm' => [2, 10]])

Could be something like

->asRow(bs()->formRow()->sm(2, 10)->md(3, 10))
->asRow(bs()->formRow()
    ->sm(false, 10)) // false means that we should ignore column and offset the next one

See https://github.com/spatie/laravel-html/blob/master/CHANGELOG.md#2200---2019-01-18.

Fatal error: Access level to MarvinLabs\Html\Bootstrap\Elements\Traits\SizableComponent::size() must be public (as in class Spatie\Html\Elements\Input)

BS4 issue.

See twbs/bootstrap#20813
See twbs/bootstrap#23994 (closed as dup of the above issue)

bs()->radio('test')

gives the error:

Type error: Argument 1 passed to MarvinLabs\Html\Bootstrap\Elements\Radio::description() must be of the type string, null given

the MarvinLabs\Html\Bootstrap\Traits\BuildsForms::radio() method allows null values:

public function radio($name = null, $description = null, $isChecked = false)

but the Radio method description(string $text) does not allow null.

https://getbootstrap.com/docs/4.0/components/button-group/

Hey! How to bind model with relations? Like... I have post and have seo info for it. So, when I bind model, it works ok, but inputs with relations always null...
And validation errors don't show on relation inputs.

When adding an 'accept terms' checkbox you can not add a link to a Terms & Conditions page/doc

 {{ bs()->formGroup(bs()->checkBox('accept_terms', 'I agree with the <a href="/terms" target="_blank">Terms & Conditions</a>'), '') }}

MarvinLabs\Html\Bootstrap\Elements\CheckBox::label() uses:

 ->text($element->description)

This probably can be replaced with : ?

 ->html($element->description)

https://getbootstrap.com/docs/4.0/components/jumbotron/

Hi, first of all, thanks for this awesom package, it is just what i was looking for.

However, I'm having a slight issue regarding validation and showing error messages. Right now, if validation fails, the fields get correct is-invalid class but i cannot see the error message from the validator (e.g. Field :field is required).

Here is my code:

<div class="row mb-3">
    <div class="col-6">
        {!! bs()->text('first_name')->placeholder(__('core::register.form.first_name')) !!}
    </div>
    <div class="col-6">
        {!! bs()->text('last_name')->placeholder(__('core::register.form.last_name')) !!}
    </div>
</div>
{!! bs()->inputGroup()->addClass('mb-3')->prefix("<span class='input-group-text'><i class='icon-user'></i></span>", false)->control(bs()->email('email')->placeholder(__('core::register.form.email'))) !!}
{!! bs()->inputGroup()->addClass('mb-3')->prefix('<span class="input-group-text"><i class="icon-lock"></i></span>', false)->control(bs()->password('password')->placeholder(__('core::register.form.password'))) !!}
 {!! bs()->inputGroup()->addClass('mb-3')->prefix('<span class="input-group-text"><i class="icon-lock"></i></span>', false)->control(bs()->password('password_confirmation')->placeholder(__('core::register.form.password_confirmation'))) !!}

And here is a screenshot after failed validation:

Do i need to do something more for the error messages to show up?

Thanks

I would like to know if it support Horizontal Form or not.
Does it? Or will it?

We should be able to set an attribute on all radios of a group when creating the group

Hi
This is great, but how do you show validation errors against the fields? (.is-invalid, .invalid-feedback etc?)
I see references to it within the package, but I can't find any example of implementing it.
Thanks

The radio buttons in the group are properly highlighted in red, but no error message is appended below the group.

For instance, it would be handy to specify which default classes should be applied to form groups, or maybe too which wrapper around the form control gets applied.

Would help reducing the code to build forms by a lot.

For example custom checkboxes, custom files, custom radios, etc.

There is no way to set an attribute on the wrapped element.

Maybe via magic __call

Something like controlAttribute, controlAddClass, etc.