martinmoene / byte-lite Goto Github PK

byte lite - A C++17-like byte type for C++98, C++11 and later in a single-file header-only library

License: Boost Software License 1.0

CMake 14.27% C++ 62.56% Batchfile 6.75% Python 15.86% Starlark 0.56%

byte byte-implementations cpp17 cpp98 header-only no-dependencies single-file

byte-lite's Issues

Your byte implementation is unsafe under strict aliasing

As Richard Smith points out in https://groups.google.com/a/isocpp.org/d/msg/std-proposals/McSXSFki08I/fwKKfZqNCAAJ, your byte implementation would be unsafe under strict aliasing optimisation.

The solution is to mark up your byte type with __attribute__((__may_alias__)) on GCC and clang, For MSVC, currently, unless you use __declspec(noalias) and/or __declspec(restrict), everything is assumed to alias, though Microsoft promise that strict aliasing optimisation is coming at some point soon.

Change license to BSL

Failure on big-endian architecture

Hi, byte-lite appears to fail the tests in a big-endian configuration.
For context, it was an automated build having the s390x architecture enabled.

/builddir/build/BUILD/byte-lite-0.3.0/test/byte.t.cpp:193: failed:
byte: Allows strict aliasing: 14 == F::f( i, reinterpret_cast<nonstd::byte&>( i ) ) for 14 == 7

builder-live.log.gz