marthag8 / cookbook-thruk Goto Github PK

Hello,

Please add ability to store secret.key content in chef node attribute. It's will be useful when you configuring multi thruk installation and add some thruk like http backend.

The new package version of thruk have depend from thruk-base package and not install.

For solve it maybe use the Labs Repository with there are all needed packages.

Please add attributes thruk.conf to default attributes or add escape it from template if attributes not exist.

thanks.

Latest version of Thruk (v1.84-6) use libmysqlclient18 package in depends.
Maybe use the attribute type %w with list of package in recipe debian?

First I had to patch the libmysqlcleint16 and replace with libmysqlclient18 but now I am running into, the below.

[2013-11-13T05:17:12+00:00] FATAL: Net::HTTPServerException: remote_file[/var/chef/cache/thruk_1.72-2_debian12_amd64.deb](thruk::debian line 11) had an error: Net::HTTPServerException: 404 "Not Found"
vagrant@vagrant-jb-thruk-test:~$ dpkg-query -W thruk | grep -q '^thruk[[:blank:]]1.72-2$'

Hi Martha,

Great cookbook, thank you for publishing this!! Having just implemented it on a server, it is a chance to submit feedback and a QA report to you at no charge. :-) The cookbook has worked fine. Here are some small items to possibly consider changing:

This template is only in the section "if node['thruk']['use_ssl']", however it could be added more globally, no? If the server name is customized then it needs to be present:

template '/etc/default/thruk' do
source 'thruk-default.erb'
mode '0644'
end

The cookbook currently requires you to set at least one thruk configuration, or this error occurs:

Chef::Mixin::Template::TemplateError (undefined method `each' for nil:NilClass) on line #9:

     7: # those from the thruk.conf
     8: ############################################
     9: <% node['thruk']['conf'].each do |k,v| %>
    10: <%= k %> = <%= v %>
    11: <% end %>

But will the thruk server really be broken if you just go with all defaults there? It ought to be permitted, right?

Feature enhancement:

Thruk mainly interfaces with Nagios, Icinga, Shinken and Naemon. Neither the Shinken cookbook nor the Thruk cookbook has chef code to automatically set up Thruk with Shinken. This is a gray area between the two cookbooks, you might say the code should actually go in the shinken cookbook. Anyway, to think about more, maybe just add a couple pointers in the docs, since it is related to the topic of Thruk.