marinarukavitsyna / testcafe-screenshot-testing Goto Github PK

In the /TestCafe-Screenshot-Testing/example/index.js file the following imported file is missing
import compareScreenshots from './modules/compare-screenshots' is missing``

It is possible to add it please ?

Thanks a lot.

Hi,
Glad to find your job as a good example for testcafe screenshot stuff. Thanks for sharing.
However, there is a small issue in compare-screenshots.js:12. The Rembrandt init param
maxDelta: 20,
does not seem to be correct.
I think you should put a percentage in float. Otherwise, it'll always return true !

See Rembrandt lib example with thresholdType: Rembrandt.THRESHOLD_PERCENT

// Maximum color delta (0...1):
  maxDelta: 0.02,

Thanks

After cloning repo and running npm install, I get this error...

`> node-gyp rebuild

gyp ERR! configure error
gyp ERR! stack Error: Command failed: /usr/local/opt/python/libexec/bin/python -c import sys; print "%s.%s.%s" % sys.version_info[:3];
gyp ERR! stack File "", line 1
gyp ERR! stack import sys; print "%s.%s.%s" % sys.version_info[:3];
gyp ERR! stack ^
gyp ERR! stack SyntaxError: invalid syntax
gyp ERR! stack
gyp ERR! stack at ChildProcess.exithandler (child_process.js:294:12)
gyp ERR! stack at ChildProcess.emit (events.js:200:13)
gyp ERR! stack at maybeClose (internal/child_process.js:1021:16)
gyp ERR! stack at Socket. (internal/child_process.js:430:11)
gyp ERR! stack at Socket.emit (events.js:200:13)
gyp ERR! stack at Pipe. (net.js:586:12)
gyp ERR! System Darwin 18.6.0
gyp ERR! command "/Users/tyleroneal/.nvm/versions/node/v12.3.1/bin/node" "/Users/tyleroneal/.nvm/versions/node/v12.3.1/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/tyleroneal/repos/TestCafe-Screenshot-Testing/node_modules/canvas
gyp ERR! node -v v12.3.1
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok
npm WARN Screenshot_Testing@ No repository field.
npm WARN Screenshot_Testing@ No license field.

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] install: node-gyp rebuild
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
`

https://github.com/Automattic/node-canvas is now canvas
So maybe, readme could be updated with `Install canvas for Node.js``