Hello !

thanks for this library, i've tried a lot of color extraction php libs and this one is by far the best.

But there's a problem when converting a color to HSL the hue value seems wrong.

$color = new \marijnvdwerf\palette\Color\RGBColor(0.8, 0.5, 0.2)

(string) $color
// => "rgb(204, 128, 51)"
// this is right

(string) $color->asHSLColor()
// => "hsl(0.000000, 60.000000%, 50.000000%)"
// this is wrong

(string) $color->asHSLColor()->asRGBColor()
// => "rgb(204, 51, 51)"
// this is different from the color we entered in the constructor

Best regards,

Could you please define a License for this so I can figure out if I am able to use it?

I'm not sure if what I'm about to suggest is a good idea, but I was surprised to see zero-population swatches turn up in my results. This is caused by L123 and L133 in Palette:generateEmptySwatches.

Would it be possible (or worthwhile) to include a non-zero population count for generated swatches? One option might be to take the generated color, and re-analyze the image to determine the population of pixels that approximate that color. Another option might be to use the dark swatch population in its stead.

In my implementation, I'm just looking to extract a single dominant color, so if the vibrant color is missing its population, I ignore it and fall back to dark vibrant.

The reason I'm asking is because I'm intending to use the population together with image size to generate a fill percentage, which will be used as a factor in weighing score when searching by color.

I'm not sure if I'm looking for solutions here, but I'd be interested in a discussion. Hopefully, if someone else is confused by zero populations appearing in their results, this will help them track down the cause.

Hello,

With some images I get this error :

max(): Array must contain at least one element
Palette.php","line":81,"function":"max"

I tracked the error down and it's caused by the shouldIgnoreSwatch function, and more precisely to isNearRedILine.

I don't understand the meaning of isNearRedILine but it's causing the swatches array to be empty.
Would be nice if we could customize shouldIgnoreSwatch as proposed here : #12
Or at least if Palette.php could handle an empty array without throwing an error.

Example image:

Surely I can work on a PR if you explain the meaning of isNearRedILine

Thanks

We have some issues by using your library. We ran mostly in the isNearRedILine() case.

So my suggestion is to allow user to configure the ignore types.

Would be great if you can adapt this.

An array of colors can be empty when there are no colors in the image.
In the function max and min, you can not pass an empty array, otherwise the function will return false and throw warning.

Stacktrace:

Warning: max(): Array must contain at least one element

Exception trace:
 () at vendor/marijnvdwerf/material-palette/src/ColorCutQuantizer.php:101
 marijnvdwerf\palette\Vbox->getVolume() at vendor/marijnvdwerf/material-palette/src/ColorCutQuantizer.php:39
 marijnvdwerf\palette\ColorCutQuantizer->quantize() at vendor/marijnvdwerf/material-palette/src/PaletteGenerator.php:47
 marijnvdwerf\palette\PaletteGenerator->generate() at vendor/marijnvdwerf/material-palette/src/Palette.php:59

Sample code

$manager = new ImageManager();
$image = $manager->make('filename');
$palette = Palette::generate($image);
$palette->getVibrantSwatch()->getColor();

Problem image

Hello,

I'd like to get the population of the different swatches but with a tolerance, for example :
population of the vibrant swatch +/- 10% on H, S, and L.

I understand that at this point, I have all the image's colors with their populations:
https://github.com/marijnvdwerf/material-palette-php/blob/master/src/PaletteGenerator.php#L46

But then I don't understand what's going on witht the VBox class, what does it do ?

Any hint on how to achieve this ?

Thanks

First off, really like this tool. Thanks for putting it together.

My question concerns performance.

I am using Intervention Image with GD on a 250x 250 px image and am seeing the Palette::generate($image) method take 3 seconds for this single small image. This is on a recent i7 macbook running PHP 5.6 on MacOS. The quantize($swatches, 16) call within the PaletteGenerator->generate() method is where all the time is spent.

Is this expected?

See Palette.php#L129. Minor typo, but if I'm reading it right, it looks like it'll prevent an empty darkVibrantSwatch from being generated from vibrantSwatch.

Can you provide instructions in the readme on how to install without composer (as not everyone uses it) and also an example using gd, as I can't install imagemagick on my server.
Thanks