Code Monkey home page Code Monkey logo

openpoimap's People

Contributors

bonanza123 avatar cdauth avatar jeinzi avatar marczoutendijk avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

openpoimap's Issues

Feature: add edit links at the top of the screen

Currently, the edit links appear when we click on a POI.
However:

  • If there aren't any POI in the area, there is no way to quickly edit the area
  • If there is a POI but not just next to the one we want to add, the edit area will be shifted

Proposed fix: add the edit links at the top of the screen, next to the OpenPoiMap box (or below it).
presse-papiers-1

License?

I am planning to implement a function similar to OpenPOIMap into FacilMap. While I haven’t decided the details yet, I think that the source code of OpenPOIMap would be a good inspiration, and the list of amenities is a good collection of POI types.

I am thus wondering under which license the source code of OpenPOIMap is published. I was not able to find any details about this. Can I reuse parts of the source code in my project?

Feature: replace the Permalink by a dynamic url change

Using history.replaceState(), the Permalink isn't needed anymore since the browser url changes dynamically. And the browser page can be easily refreshed to check for changes on osm.

See https://developer.mozilla.org/en-US/docs/Web/API/History_API#Adding_and_modifying_history_entries for the details.

So you can use this:
window.history.replaceState(“”, “OpenPoiMap - Taglocator”, “/~marczoutendijk/openpoimap/taglocator.html?map=amenity&zoom=[zoom]&lat=[lat]&lon=[lon]&layers=[layers]”);
The variable parameters being [zoom], [lat], [lon] and [layers] (without []).

HTTPS links

There is a problem due to the use of "HTTPS everywhere" extension which comes with a profile for openstreetmap.org.
The problem is that this plugin enforce HTTPS on all links to openstreetmap.org which seems to fail on this awesome website.
It look like changing the openstreetmap.org links (and maybe others too?) solves that problem.

images for pois not available

Hi Marc, thx for this nice application.
I am struggling to get images displayed for pois.
Some could use wikimedia_commons Category to retrieve the image, or wikipedia api...
but i see that you have already implemented the logic.
Is that part of the code updated? No poi shows any image
Thx again :)

Tagged parts of POI's way are mistakenly marked as separate POIs

While I was checking for nearby local libraries in OpenPoiMap, I encountered an oddity on how it treated specially-tagged node which is a part of "way"-type POI. Namely, if the "way" matches the current POI search criteria, each of these specially-tagged nodes would also sprang up as duplicate POIs, depsite the fact that these nodes' tags are not matching current POI criteria by themselves. Non-tagged nodes of the way seems not to be affected by this problem.

Exact steps to reproduce:

Screenshot

The actual POI in question is "หอสมุดแห่งชาติ" ("National Library") of type "way", marked with amenity=library tag, which is rightly flagged by OpenPoiMap. But the rest two are incorrectly flagged: these are "nodes" (1) (2) marked solely with barrier=gate tag; which are entrance gates to the library ground. Clicking these incorrectly-marked nodes will make the main "way" show its information dialog (screenshot).

For the record: At the time of writing, the latest change to the affected "nodes" is changeset 53062603, and latest change for the main "way" is changeset 54263885; both are authored by me through OpenStreetMap.org's online Potlatch2 editor.

Browser: Pale Moon 25.8.1 (GNU/Linux)
OpenPoiMap: 1.28 (openpoimap.org)

POIs are not loading due to wrong overpass uri

I just came across openpoimap and I found that the POIs are not loading at all. When I looked at the network calls with the Chrome developer tools, I found that the page calls overpass like this:

http://overpass-api.de/api/interpreter/http://overpass-api.de/api/interpreter/?data=(node[tourism=chalet](bbox);way[tourism=chalet](bbox);rel[tourism=chalet](bbox););(._;%3E;);out%20center;&bbox=-8.2352790898347,37.636953943645,-8.2174048482753,37.666548537167

So the POIs not loading is probably due to the messed up schema and host in the url.

When loading the page, and having all selected, I cannot click on nor open the infoWindow of any Restaurant until I click on another icon

Hello Marc,

First, thanks for such a great script.

One thing I noticed was that the amenities load very slow,
To a point in which the restaurant doesn't even load.

I made a video: http://nearfy.com/OpenPoiMap_behavior_001.mov

the permalink for testing: http://openpoimap.org/?map=restaurants&zoom=19&lat=50.85048&lon=4.35482&layers=B00TTTTTTTTT

1st) I reload the page ( before the video )
2nd) I clicked on restaurants
3rd) clicked on set all
4th) set a permalink
5th) reload page ( video starts here )
6th) I see that each amenity loads slowly, but never gets to load the actual restaurants.
7th) if I click on the "Ramen" Fast Food, then it loads the restaurant.

Is there a way to make it all load at once?

I've been trying to understand how it works. I see you use a lot of API's to get different information. I see you mention a limit in calls, but didn't see any explanation about how many.

Is there a way to show a photo in OpenPoiMap? in the same way as Google Places API Photos ?

Thanks
Sebastian

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.