marcoarment / fcutilities Goto Github PK

You talked on the podcast that your open source libs don't get much attraction or contributions.... I think this one is very useful and an important thing that it's missing is a good README.md.

I created this iOS Open source Readme Template so you can take a look on how to better organize.
If you want, I can help you to do it.

What are your thoughts? 😄

This repo is awesome, and add documentation comments in the code will make this repo even better.

In commit 44510ad you removed the OAuth authentication using SFAuthenticationSession. However, in the newest version of the Twitter app, the twitterauth: URL scheme no longer starts the the authentication flow. The Twitter app is launched but nothing else happens.

I found that the old OAuth authentication flow still works fine, so that probably should be the way to go. Requires users to enter their credentials in the web view but at least it still works.

The -fc_startsWith: and -fc_endsWith: methods on NSString seem superfluous to me given that NSString already has -hasPrefix: and -hasSuffix:.

Granted, they have different characteristics if the argument is nil or an empty string, but is that really relevant for these methods? Passing nil or an empty string as a argument to -fc_startsWith: or -fc_endsWith: looks like a programmer error to me.

I'd be cool to also add Cocoapods support. I done this implementation myself last month for my library. Just follow this post and this checklist.