marcmaniez / babol-legacy Goto Github PK

• Don't give a link to copy.
• Stop displaying the current service options, or make it smaller
• Make a separate route for creating links that will take you to the new page without risking redirecting you to Apple or Spotify.

Replace isMatch function with Levenstein module and normalize inputs (no caps, accents, etc.)

Antonio Carlos Jobim returns empty Apple Link

https://open.spotify.com/artist/3pO5VjZ4wOHCMBXOvbMISG

Tell users what happened when a link isn't delivered.

Or else people don't really know what to put on the box or what to expect :)

Prepare with grunt and deploy to Heroku.

Some links don't return anything due to a range of issues. There will always be some. This issue will never close. Track them here, investigate them.

• https://itun.es/us/CRjF4?i=947690225 (score not high enough) FIXED (returned 50 search results instead of 20)
• https://itun.es/us/nCTuB?i=458413993 (Spotify API returned no results) FIXED (added a search for album and artist under the song category as a last resort, when no other search combo had returned a result)
• spotify:album:1xl2oh7njuwSneP6tLfdvN (reported by Josh) FIXED (issue with the service detection regex for Spotify uris)
• https://itun.es/us/nCTuB?i=458413936 FIXED (up songless song search up in priority — include it in initial group of searches).
• https://itun.es/us/RLC
• https://itun.es/us/xQJ3Q — Could not retrieve any results form Spotify API.
• https://itun.es/us/Amu_Q — No link with high enough score.
• spotify:track:4fMXQkXkfmO6KWKVwxvkWT — Works in dev, but not in production.
• https://open.spotify.com/track/2tkyEHSkv0I3l4OkBe1FnO — ???

If multiple albums of the same name exist (but with a different artist), we run into issues searching for a song (or even for an album)

For example:
https://itun.es/us/djGbr?i=285606968 is currently an issue because we have an entry for Sweet Rain under artists a) Stan Getz, Chick Corea & Bill Evans and b) Chick Corea, Stan Getz & Bill Evans.

When searching for Windows by Chick Corea, Stan Getz & Bill Evans, we return the version of the album Sweet Rain belonging to Stan Getz, Chick Corea & Bill Evans.

This kind of issue is likely to happen more often as entries become more and more numerous. As soon as multiple artists have the same album name, we will have issues of this kind.

eg https://itun.es/us/nCTuB => https://itun.es/us/nCTuB?i=458413936 !

If a link is requested which already exists in the database, but is not shortened ==> replace the long version with the short version that has likely just been provided by the user.

Create findOrCreate for a piece of content.
Break it down to a few basic operations per service:

• Get ID
• FindOrCreate

Implies some choice given to the user when they click a link to a music service, and an interface to allow the option to not be automatically redirected to links from such service in the future.