The three4j from marchof

marchof / three4j Goto Github PK

View Code? Open in Web Editor NEW

Threema Gateway Client for Java

License: MIT License

Java 100.00%

three4j's People

Contributors

Stargazers

Watchers

three4j's Issues

Ensure message data length is at least 32 bytes

See: https://gateway.threema.ch/en/developer/e2e

Missing values in Gateway.Capability

General Description:

It seams like Threema has updated the possible capabilities and now Gateway.Capability is missing some values.

Way to reproduce:

When I try to request the capabilities of my ThreemaId with Gateway#getCapabilities(ThreemaId threemaid) I receive the following exception:

Exception in thread "main" java.lang.IllegalArgumentException: No enum constant com.mountainminds.three4j.Gateway.Capability.ballot
	at java.base/java.lang.Enum.valueOf(Enum.java:273)
	at com.mountainminds.three4j.Gateway$Capability.valueOf(Gateway.java:232)
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
	at java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:992)
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
	at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921)
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682)
	at com.mountainminds.three4j.Gateway.getCapabilities(Gateway.java:248)

Reason

The reason is that the result of the request contains ballot,call,videocall,image,file,text,video,audio,pfs,group,groupcall and the enum only contains text, image, video, audio, file.

Suggestions

The missing values should be added to the enum
Instead of using Capability::valueOf some other mapping method should be used that doesn't throw an exception when trying to map to Gateway.Capability
Example:

stream(result.split(","))
           .map(str -> Arrays.stream(Capability.values()).filter(cap -> cap.name().equals(str)).findFirst())
           .filter(Optional::isPresent)
           .map(Optional::get)
           .collect(toSet());

Recommend Projects