Use unsafe immutable collections for JSON parsing about fast_immutable_collections HOT 4 CLOSED

Absolutely. Good catch! I will fix this.

from fast_immutable_collections.

Done. Note just the IMap had this problem. IList and ISet where created differently. Thank you.

from fast_immutable_collections.

@marcglasberg Can you explain why IList and ISet don't have this issue?

Both IList.fromJson and ISet.fromJson use their default constructors to create their respective collections which AFAIK does create copies unlike ISet.unsafe and IList.unsafe.

from fast_immutable_collections.

IMap is creating a map first, and then locking it.

But IList and ISet are not. For those you have an Iterable, and then you lock it directly. The Iterable is lazy, it will be used internally when creating the IList/ISet. No intermediary mutable List or Sets are created in this case.

from fast_immutable_collections.