Comments (9)
At this point, I have half a mind to fork the project and call it fast_immutable_collections_plus and put it under the Flutter Community care. Seems @marcglasberg has gone silent.
from fast_immutable_collections.
I have, however, added an example, to get an extra 10 pub points, and turned some http links into https, to get some extra pub points. Now we're at 130 out of 140 points.
from fast_immutable_collections.
I'm a bit concerned that this is the tip of the iceberg, seeing this:
include: package:lint/analysis_options.yaml
linter:
rules:
curly_braces_in_flow_control_structures: false
omit_local_variable_types: false
prefer_single_quotes: false
prefer_double_quotes: false
no_leading_underscores_for_local_identifiers: false
no_runtimeType_toString: false
avoid_multiple_declarations_per_line: false
parameter_assignments: false
avoid_dynamic_calls: false
avoid_redundant_argument_values: false
avoid_print: false
always_use_package_imports: false
avoid_positional_boolean_parameters: false
prefer_const_literals_to_create_immutables: false
prefer_interpolation_to_compose_strings: false
avoid_function_literals_in_foreach_calls: false
cast_nullable_to_non_nullable: false
require_trailing_commas: false
join_return_with_assignment: false
unnecessary_parenthesis: false
use_is_even_rather_than_modulo: false
use_string_buffers: false
I'd strongly recommend looking at package:very_good_analysis, and turn off nothing, and see how close one can get to superclean.
from fast_immutable_collections.
Is there any interest by @marcglasberg in supporting a third party to fix up this package? Or is there a secret new branch somewhere that solves the issues?
from fast_immutable_collections.
Removing disabled lint rules uncovers 18 errors, 5 warnings, and 177 infos even after running dart fix --apply
. I think this problem is critical.
from fast_immutable_collections.
Has this had any movement. I just hesitantly recommended FIC again, and I'd like to have more confidence in this codebase.
If someone fixes this and gives you a PR, will you look at it?
from fast_immutable_collections.
I have not made any progress on this one.
from fast_immutable_collections.
As I wrote in Slack too, it would be much better to transfer the ownership instead of forking, if @marcglasberg isn't interested in maintaining it anymore (and otherwise just create a PR with the fixes).
Since he is active on GitHub I don't think he is completely gone, but most likely just busy with other things.
from fast_immutable_collections.
Hey guys, thanks for the report. But don't worry, I am actually still maintaining this package and about a dozen others, and will do so for the foreseeable future. I have my own analysis_options.yaml
file that contains the rules I care about. I don't like the default linter, and I don't want to follow it. I use 100 char lines instead of 80 char lines, and then pub.dev doesn't like it because they are authoritarian and think that everyone should follow their preferred code style, which I don't like and won't follow. The code is well tested and it follows my conventions. So, yes, not following their exact code style rules reduces the pub points, but that's unimportant, and will have no impact whatsoever on the users of the package. It's also well documented to great detail, as far as I know. If you miss any documentation let me know and I will provide it. I am closing this issue because I don't intend on making changes to try and get more pub points. Thank you.
from fast_immutable_collections.
Related Issues (20)
- `averageBy`'s documentation code is that of `sumBy` HOT 1
- Dart Error: error: illegal recursive type 'IMap<C1X0, C1X1>' HOT 2
- IList.update HOT 1
- Use of Fast Immutable Collections with Freezed results in dynamic types HOT 4
- Use unsafe immutable collections for JSON parsing HOT 4
- Const constructors? HOT 1
- Add `firstWhereOrNull` method HOT 1
- Incompatible with json_serializable toJson/fromJson: issue _safeKeyFromJson HOT 2
- Can Tuple2 be removed with Dart 3.0 now having Records? HOT 5
- IListConst when empty has not type HOT 3
- Suggestion: Use `@useResult` instead of `@useCopy` (or use both) HOT 1
- IHashMap Implementation HOT 3
- What is the most straightforward way to replace an item on an ISet? HOT 1
- IList `replaceFirstWhere` unnecessary nullable HOT 4
- Best Practices for Mutating Collections Multiple Times HOT 1
- Sliding
- ISet.difference does not always return the correct result HOT 1
- IMap update throw "Null check operator used on a null value" HOT 1
- operations on IList.empty() (and others) do not work when modified HOT 11
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fast_immutable_collections.