marcelcoding / bszet-vplan Goto Github PK

The room changed to B110.

Do not use variables that are some times undefined. Undefined means that they are not mentioned in the JSON dictionary at all. This is a pain if you don't use a template for parsing the JSON (not every language is strongly typed). And when it comes to the cancelled boolean: set it to false if it isn't set to true. If a variable is empty set it to null.

Keep in mind that this way the API documents itself and people who are trying to implement it don't have to read your code and don't need to use .get everytime.

10.10.2022

🤬🤬🤬🤬🤬

The room has changed to B 110 and is not B 112 anymore.

As already mentioned in #35 there has been some problems with groups. Originally the group functionality was for the groups in the IGD21 which are the same through every subject. This was the main reason BK was split into BK_1 and BK_2 because those groups were not the same as the other groups.
Since trying to add the IG21 timetable it turned out that this group system is not working anymore because every subject has different groups. Also the Python API dosen't parse the groups at the time of writing this.
There are two options going forward:

• we split every subject with multiple groups into multiple subjects
• we implement group parsing into the python api ignoring the fact that a group could mean multiple things

E.g. 10.10.2022

lf11d_i2 seems to include the group number after the i? Should we actually parse this? Is this a job for python backend? Is the new syntax used all the time now?

👏👏Global variable review

It dosen't help anybody to get the timetable of the current day at 1pm. Please preview the timetable for the next day. Maybe send the current timetable until 8am and then switch.

Mfs have some really weird abbreviation for math tutoring these days. (Might have to call it something else in the bot.)
Or ignore entirely cuz it's an optional curriculum.

For example: IGD21 2021-10-05

TKFRvisionOfficial/bszet_substitution_plan#32

In #44 and #42 there were some changes that will break ig21 support. Because INFO is actually a subject for ig21 and used to defie LF6 in igd21 there is a conflict. Certain classes need there own subject collections. A split between IG and IGD would suffice for now. Ofcourse we will keep the domain.ts for subjects that are shared between those two classes.

Sentry Issue: BSZET-VPLAN-24

Error: Timetable change action "other" not implemented.
  File "./src/timetable/changes.ts", line 66, in handleChange
    throw new Error(`Timetable change action "${change.action}" not implemented.`);
  File "./src/timetable/changes.ts", line 17, in forEach
    if (handleChange(timetable, change)) {
  File "./src/timetable/changes.ts", line 13, in applyChanges
    changes.forEach((change) => {
  File "./src/timetable/index.ts", line 50, in getActualTimetable
    applyChanges(clone, changes);
  File "./src/vplan.ts", line 50, in processClass
    day = await getActualTimetable(clazz, date, changes);
...
(1 additional frame(s) were not displayed)