Comments (1)
Thanks for bringing this up, I did not expect the jQueryUI widget _trigger
method to be that slow.
Performance is always an important issue, and there are already some benchmarks
http://wwwendt.de/tech/fancytree/test/unit/test-bench.html
I added a test case for _trigger:
10000 createNode DOM events (widget._trigger()) took 294 milliseconds, 34,014 items/sec
10000 createNode callback events (options.createNode() defined) took 5 milliseconds, 2,000,000 items/sec
10000 createNode callback events (options.createNode() undefined) took 4 milliseconds, 2,500,000 items/sec
I think I will replace the _trigger call with a direct function call options.createNode
,
as the execution time becomes neglectable.
The drawback is, that no additional DOM event is fired that a user can bind("fancytreecreatenode")
to.
As to your other remarks:
The render function should add the elements to the DOM in one final step, hence the comment
// Finally add the whole structure to the DOM, so the browser can render
at least that was the plan. I will check again.
The table extension
already uses createDocumentFragment
. Maybe that will also help to improve performance for the standard renderer.
from fancytree.
Related Issues (20)
- Editing a node title Loses Custom CSS button after editing HOT 1
- getPath() does not work HOT 3
- "No Data" ....Even after adding Children HOT 1
- Hovering issue in Viewport HOT 3
- minExpandLevel: 2 together with `table` extension does not work HOT 1
- Folder Missing Plus / Minus HOT 4
- Duplicate keys after tree is loaded from URL HOT 4
- Update jQuery UI to 1.13.2 HOT 3
- Cannot read properties of undefined (reading 'fancytree') HOT 4
- Change title property to some other property HOT 1
- DragDrop - error in console cause my object has circular references HOT 4
- Question: Can this work without jquery? HOT 1
- Fanctree expand is not working for the first expand click HOT 1
- filter/search: prevent node from expanding HOT 1
- remove extra space between icon and title HOT 1
- on iphone first touch does not expand/is ignored HOT 1
- getNodeByKey issue HOT 5
- Drag and drop feature doesn't scroll when dragging out of bounds on Grid + Viewport setup HOT 2
- Bump jQuery UI to 1.13.2
- Lazyload of a child node with postProcessing fails HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fancytree.