ESLint and Prettier auto-fixes are ignored by the build-flow. about maplibre-gl-directions HOT 5 OPEN

Yes

from maplibre-gl-directions.

In GL JS, we use eslint to check if everything is fine and if warnings and errors occur, the workflow fails. Then the user just needs to run something manually like npm run lint -- --fix, solve the problem, and commit the change. I prefer this over automatic commits made by the workflow because it is easier to understand for new people, the commits are controlled by a human, and follow-up workflows will run automatically (GitHub has some rules that workflows should not trigger workflows to avoid loops...).

from maplibre-gl-directions.

@wipfli sound reasonable enough. But what about the Prettier? It only affects formatting, and I really prefer all the codebase to be style in the same manner. There are no guarantees that each contributor will manually run the Prettier script locally (I even frequently forget to do so myself), so I think it's a good idea to run it during the automated build. What do you think?

from maplibre-gl-directions.

Yes completely agree. Let's run Prettier in CI and if something is bad, the workflow should fail. We will only merge things with green CI so like this the codebase stays clean...

from maplibre-gl-directions.

@wipfli so you mean without auto-fixes on the Prettier side? Just the failing build if something's out of place?

from maplibre-gl-directions.