C++11 fixes about carmen-cache HOT 7 CLOSED

Awesome, I've been pushing on more ported js code here https://github.com/mapbox/carmen-cache/tree/spatialmatch if you want to keep being my guardian angel : )

from carmen-cache.

@springmeyer if you have a chance tonight would love your gut reaction to the memleak going on in spatialmatch-memtest branch:

https://github.com/mapbox/carmen-cache/blob/spatialmatch-memtest/test/spatialMatch.test.js

I'm probably doing something n00bishly horrible : (

from carmen-cache.

@yhahn - does not look like a memory leak. I see the constant growth of memory until the test ends, however it looks like its just because garbage collection is not kicking in. I have this hunch because memory stays constant for me at ~180 MB if I do:

node --expose-gc ./node_modules/.bin/tape test/spatialMatch.test.js

With:

diff --git a/test/spatialMatch.test.js b/test/spatialMatch.test.js
index f5222e7..b682e80 100644
--- a/test/spatialMatch.test.js
+++ b/test/spatialMatch.test.js
@@ -22,6 +22,7 @@ for (var i = 0; i < 10000; i++) test('unit ' + i, function(assert) {
     var args = require('./fixtures/spatialMatch-args.json');
     spatialMatch(args[0], args[1], args[2], args[3], function(err, ret) {
         firstRun = firstRun || process.memoryUsage();
+        gc();
         assert.ifError(err);
         assert.deepEqual(ret, require('./fixtures/spatialMatch-ret.json'));
         assert.end();

from carmen-cache.

So, we may need to start using NanAdjustExternalMemory (which calls out to v8::AdjustAmountOfExternalAllocatedMemory) to give V8 a hint that carmen-cache is using memory so that garbage collection is triggered more often.

from carmen-cache.

Hrm, seeing in actual testcases that gc is not making a difference -- cache definitely seems to be eating more memory and getting progressively slower for the same operations.

Will dig a bit more.

from carmen-cache.

Hmm, okay, so must be something else going on that the simple testcase did not cover?

from carmen-cache.

capturing chat: we found the mini-memleak: 376c994

from carmen-cache.