Use `numeric_cast` for narrowing conversions about carmen-cache HOT 2 CLOSED

More context:

• An error like this is also known as a truncating conversion. Is is not undefined behavior, but it is usually unwanted behavior that should be protected from
• The only current way to detect it is with the -Wconversion warning. However the use of static_cast will silence this warning making it hard to detect (this is why I recommend manual detection and throwing based on numeric_cast).

There is some discussion of adding support for assignment based detection of truncating conversion in clang++: http://clang-developers.42468.n3.nabble.com/A-need-for-an-quot-fsanitize-integer-assign-overflow-quot-td4037252.html#a4037318

Looks like this library might have what we need: https://cs.chromium.org/chromium/src/base/numerics/README.md

Or this one: https://github.com/narizhny/numeric_safety

from carmen-cache.

Closing, since this is more of a discussion piece than actionable. This ticket was created to discuss ways to avoid bugs like #82, but in reality tooling can't really catch all these bugs and unit tests are the way to ensure correct behavior (which we now have for #82).

from carmen-cache.