Code Monkey home page Code Monkey logo

convertctrees's Introduction

Hi there ๐Ÿ‘‹๐Ÿฝ

โ˜๐Ÿฝ Pronouns: He/him

๐Ÿ’ฌ Ask me about: How to optimise software

๐Ÿ“ซ How to reach me:

โšก Fun fact: I know waaay too much about flights and booking award tickets


Tech & Tools Preference

Techniques

Hardware/OS


My github stats

convertctrees's People

Contributors

manodeep avatar

Stargazers

 avatar

Watchers

 avatar  avatar  avatar  avatar

convertctrees's Issues

Flag to show flyby centrals

The correction for multiple z=0 FOF roots in fix_flybys means that there is no way to know if a halo had a flyby. Can be easily accommodated by flipping a bit - signalling that even though the halo appears to be a subhalo at z=0, that halo was identified as an isolated host by rockstar/consistent-trees.

Compiler warnings

@darrencroton got this output while compiling. Two issues:

  • Those compiler warnings are real and need to be fixed.
  • gcc is clang but the Makefile should pick that up (and not use the -Wa,-q flag needed to use the clang assembler for true gcc)
gcc -DUSE_STRINGPARSE -ggdb  -Wsign-compare -Wall -Wextra -Wshadow -Wunused -std=c99 -g -m64 -fPIC  -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -D_BSD_SOURCE -D_POSIX_SOURCE -D_POSIX_C_SOURCE=200809L -D_SVID_SOURCE -D_DARWIN_C_SOURCE -O3 -Ofast -ftree-vectorize -flto -funroll-loops  -march=native -fno-strict-aliasing -Wformat=2  -Wpacked  -Wnested-externs -Wpointer-arith  -Wredundant-decls  -Wfloat-equal  -Wcast-align  -Wnested-externs -Wstrict-prototypes   -Wa,-q  -c main.c -o main.o
clang: warning: argument unused during compilation: '-Wa,-q' [-Wunused-command-line-argument]
gcc -DUSE_STRINGPARSE -ggdb  -Wsign-compare -Wall -Wextra -Wshadow -Wunused -std=c99 -g -m64 -fPIC  -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -D_BSD_SOURCE -D_POSIX_SOURCE -D_POSIX_C_SOURCE=200809L -D_SVID_SOURCE -D_DARWIN_C_SOURCE -O3 -Ofast -ftree-vectorize -flto -funroll-loops  -march=native -fno-strict-aliasing -Wformat=2  -Wpacked  -Wnested-externs -Wpointer-arith  -Wredundant-decls  -Wfloat-equal  -Wcast-align  -Wnested-externs -Wstrict-prototypes   -Wa,-q  -c convert_trees_to_lhalo.c -o convert_trees_to_lhalo.o
clang: warning: argument unused during compilation: '-Wa,-q' [-Wunused-command-line-argument]
convert_trees_to_lhalo.c:899:30: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]
            if((info[i].upid == fof_id) ) {
                ~~~~~~~~~~~~~^~~~~~~~~
convert_trees_to_lhalo.c:899:30: note: remove extraneous parentheses around the comparison to silence this warning
            if((info[i].upid == fof_id) ) {
               ~             ^        ~
convert_trees_to_lhalo.c:899:30: note: use '=' to turn this equality comparison into an assignment
            if((info[i].upid == fof_id) ) {
                             ^~
                             =
1 warning generated.
gcc -DUSE_STRINGPARSE -ggdb  -Wsign-compare -Wall -Wextra -Wshadow -Wunused -std=c99 -g -m64 -fPIC  -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -D_BSD_SOURCE -D_POSIX_SOURCE -D_POSIX_C_SOURCE=200809L -D_SVID_SOURCE -D_DARWIN_C_SOURCE -O3 -Ofast -ftree-vectorize -flto -funroll-loops  -march=native -fno-strict-aliasing -Wformat=2  -Wpacked  -Wnested-externs -Wpointer-arith  -Wredundant-decls  -Wfloat-equal  -Wcast-align  -Wnested-externs -Wstrict-prototypes   -Wa,-q  -c utils.c -o utils.o
clang: warning: argument unused during compilation: '-Wa,-q' [-Wunused-command-line-argument]
utils.c:159:62: warning: format specifies type 'size_t' (aka 'unsigned long') but the argument has type 'int64_t' (aka 'long long')
      [-Wformat]
                fprintf(stderr,"Could not write %zu bytes\n",bytes_read);
                                                ~~~          ^~~~~~~~~~
                                                %lld
1 warning generated.
gcc -DUSE_STRINGPARSE -ggdb  -Wsign-compare -Wall -Wextra -Wshadow -Wunused -std=c99 -g -m64 -fPIC  -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -D_BSD_SOURCE -D_POSIX_SOURCE -D_POSIX_C_SOURCE=200809L -D_SVID_SOURCE -D_DARWIN_C_SOURCE -O3 -Ofast -ftree-vectorize -flto -funroll-loops  -march=native -fno-strict-aliasing -Wformat=2  -Wpacked  -Wnested-externs -Wpointer-arith  -Wredundant-decls  -Wfloat-equal  -Wcast-align  -Wnested-externs -Wstrict-prototypes   -Wa,-q  -c progressbar.c -o progressbar.o
clang: warning: argument unused during compilation: '-Wa,-q' [-Wunused-command-line-argument]
gcc -DUSE_STRINGPARSE -ggdb  -Wsign-compare -Wall -Wextra -Wshadow -Wunused -std=c99 -g -m64 -fPIC  -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -D_BSD_SOURCE -D_POSIX_SOURCE -D_POSIX_C_SOURCE=200809L -D_SVID_SOURCE -D_DARWIN_C_SOURCE -O3 -Ofast -ftree-vectorize -flto -funroll-loops  -march=native -fno-strict-aliasing -Wformat=2  -Wpacked  -Wnested-externs -Wpointer-arith  -Wredundant-decls  -Wfloat-equal  -Wcast-align  -Wnested-externs -Wstrict-prototypes   -Wa,-q  -c stringparse.c -o stringparse.o
clang: warning: argument unused during compilation: '-Wa,-q' [-Wunused-command-line-argument]
In file included from stringparse.c:9:
./strtonum.c:119:15: warning: comparing floating point with == or != is unsafe [-Wfloat-equal]
  if (savedval==0) return copysign(0, sign);
      ~~~~~~~~^ ~
In file included from stringparse.c:11:
./strtonum.c:119:15: warning: comparing floating point with == or != is unsafe [-Wfloat-equal]
  if (savedval==0) return copysign(0, sign);
      ~~~~~~~~^ ~
2 warnings generated.
gcc -DUSE_STRINGPARSE -ggdb  -Wsign-compare -Wall -Wextra -Wshadow -Wunused -std=c99 -g -m64 -fPIC  -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -D_BSD_SOURCE -D_POSIX_SOURCE -D_POSIX_C_SOURCE=200809L -D_SVID_SOURCE -D_DARWIN_C_SOURCE -O3 -Ofast -ftree-vectorize -flto -funroll-loops  -march=native -fno-strict-aliasing -Wformat=2  -Wpacked  -Wnested-externs -Wpointer-arith  -Wredundant-decls  -Wfloat-equal  -Wcast-align  -Wnested-externs -Wstrict-prototypes   -Wa,-q  -c check_syscalls.c -o check_syscalls.o
clang: warning: argument unused during compilation: '-Wa,-q' [-Wunused-command-line-argument]
gcc main.o convert_trees_to_lhalo.o utils.o progressbar.o stringparse.o check_syscalls.o  -flto -lm -ggdb  -Wsign-compare -Wall -Wextra -Wshadow -Wunused -std=c99 -g -m64 -fPIC  -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -D_BSD_SOURCE -D_POSIX_SOURCE -D_POSIX_C_SOURCE=200809L -D_SVID_SOURCE -D_DARWIN_C_SOURCE -O3 -Ofast -ftree-vectorize -flto -funroll-loops  -march=native -fno-strict-aliasing -Wformat=2  -Wpacked  -Wnested-externs -Wpointer-arith  -Wredundant-decls  -Wfloat-equal  -Wcast-align  -Wnested-externs -Wstrict-prototypes   -Wa,-q -o convert_trees_to_lhalo
clang: warning: argument unused during compilation: '-Wa,-q' [-Wunused-command-line-argument]
gcc -DUSE_STRINGPARSE -ggdb  -Wsign-compare -Wall -Wextra -Wshadow -Wunused -std=c99 -g -m64 -fPIC  -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -D_BSD_SOURCE -D_POSIX_SOURCE -D_POSIX_C_SOURCE=200809L -D_SVID_SOURCE -D_DARWIN_C_SOURCE -O3 -Ofast -ftree-vectorize -flto -funroll-loops  -march=native -fno-strict-aliasing -Wformat=2  -Wpacked  -Wnested-externs -Wpointer-arith  -Wredundant-decls  -Wfloat-equal  -Wcast-align  -Wnested-externs -Wstrict-prototypes   -Wa,-q  -c tests/compare_two_lhalotree.c -o tests/compare_two_lhalotree.o
clang: warning: argument unused during compilation: '-Wa,-q' [-Wunused-command-line-argument]
gcc tests/compare_two_lhalotree.o utils.o  -flto -lm -ggdb  -Wsign-compare -Wall -Wextra -Wshadow -Wunused -std=c99 -g -m64 -fPIC  -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -D_BSD_SOURCE -D_POSIX_SOURCE -D_POSIX_C_SOURCE=200809L -D_SVID_SOURCE -D_DARWIN_C_SOURCE -O3 -Ofast -ftree-vectorize -flto -funroll-loops  -march=native -fno-strict-aliasing -Wformat=2  -Wpacked  -Wnested-externs -Wpointer-arith  -Wredundant-decls  -Wfloat-equal  -Wcast-align  -Wnested-externs -Wstrict-prototypes   -Wa,-q -o compare_two_lhalotree
clang: warning: argument unused during compilation: '-Wa,-q' [-Wunused-command-line-argument]

Update snapshot number

ctrees outputs the index into scales.txt as the field snap_num. This was fixed in ctrees in commit 665cf33.

Someone trying to compare to the original halo catalog or the simulation snapshot will not be able to do so. The fix is fairly simply, all snap_num values need to be shifted by a fixed amount (basically the number of snapshots that ctrees did not use)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.