manmal / hn-android Goto Github PK

Whenever I view an article within HN, while the page is loading, I see the following artefacts:

As soon as the page is finished loading, the artefacts disappear.

I guess both HN and Chrome are using the same rendering engine. However, I do not see the artefacts in Chrome.

Any idea what might be causing this?

From Sam Charrington:

What I'm finding is that when I share an item from the internal browser's share menu, the receiving app isn't properly getting the page title. The specific use case I'm concerned with is sharing via the Buffer app, but the post title doesn't seem to be prepopulated when sharing via Twitter or Facebook either.

(Assuming this is not intended behavior.) Activities are restarted when changing device orientation on newer Android versions. #27 does not prevent this. It is probably caused by the screenSize configChange, which is also called on rotation.

You could probably fix this by easily adding "screenSize" to all the android:configChanges entries in AndroidManifest.xml:

android:configChanges="keyboardHidden|orientation|screenSize"

See http://stackoverflow.com/a/11631017 for further info.

I could not test this myself with your source because of various unrelated build errors I currently can´t fix, but with other projects, this worked well.

Screenshot of bug:

This is really annoying.

Since tapping on a comment already collapse all children comments, the long press menu > collapse comment is redundant.

Can the behavior be changed to going to root and collapsing the entire comment tree?

Why is loading more articles only limited to just one round of articles? Unless there is a good reason the user should be able to load more articles as long as he/she wants.

Disclaimer: I am not an Android developer, so apologies for any misguided notions about how sharing works.

I'm seeing this issue when sharing from hn-android to pindroid (a free pinboard.in client). When sharing from hn-android - and only hn-android - the "title" field in pindroid is populated with "Share Article URL". From other apps, pindroid is able to populate the title field with the content of the page's title tag.

I would expect hn-android to either pass the title tag's content or pass nothing (to allow the shared-to app to detect a no-title condition and fetch on its own, if that's how it works).

1. Open an article
2. Navigate within the article viewer
3. Change screen orientation
4. Original article URL is loaded and you lose your current state

All of the links give an "upvoted by you". This is probably the result of all of the upvote links still being tied to the old, non-logged in user. I think it would be appropriate to just clear the article cache after logging in.

Much like the title says, neither comments nor the list of articles are reloading. Interestingly the refresh option is just spinning and is not immediately stopping (the latter would suggest a parse error or something similar). Articles still load fine.

https://news.ycombinator.com/item?id=6467379

It's repeatable and I've sent the stack trace, not sure what else I can add to help.

Some apps (e.g. Reddit News) pop up as an option for handling http://reddit.com/ links. Is it possible to modify HN to handle all news.ycombinator.com links?

The CommentsAdapter class probably shouldn't be living in the CommentsActivity, especially as the latter handles more responsibility. It will be a little bit of a hassle because of the interactions with how the MenuListAdapter works. But it'll be worth the effort in cleanup I think (especially if both of them can go into a new file).

So I'm looking over the code in CommentsActivity while trying to figure out how to fix #46 and I ran across this question. It looks like retrieving comments is a racing operation because the application makes a call to disk and then attaches itself to any preexisting request for new comments. Is there any safeguard to protect against the network operation completing before the disk operation, and therefore having the cached comments appear instead of the latest comments?

Just a hold-over for when #62 gets merged in. In SettingsActivity the list of possible ways to render articles should just be inflated from an array if possible.

Sometimes when I read the feed list while laying on the bed on a side, the phone is rotated 90 degrees, and thus the orientation rotates automatically to be landscape; it's useless since I'm already sideways, so I can't read the news. It'd be great to have an option that would prevent the app to do so.

Every time I click on a link on a comment it both opens the link and collapses the comment thread.

It'd be nice if the app kept track of which comments have been seen, and highlighted the new ones when visiting the comments again. An example of this is when using the hckrnews.com Chrome extension plugin:

The solution of just putting a Toast there feels inelegant. There should be a way to prompt the user for login anywhere through a consistent interface.

Don't know yet exactly what's going on, but it won't stop currently. State in general is a bit messed up there, I can produce a spinning checkmark by timing the taps differently.

This is the best HN Android app there is. It would be awesome if it also prefetched comments and stories so that when you click on something in the app, it is near instantaneous. To get around HN rate limits, perhaps a server can proxy the requests (I'd be happy to donate this server).

You might want to consider the spacing.

From my Galaxy S2 (hdpi):

Is it possible to get a dark theme for those of that prefer it?

Preferably a gradient screen (LCD displays) and a true black screen (AMOLED displays).

I ran into a bug earlier today which doesn't seem to want to reproduce itself. The steps for it are:

Go to a post, upvote a comment in it
Back out of the post
Go back to the post, try to upvote the same comment
See "upvote" instead of "already upvoted by you"

I've looked a little bit into the code to find this and it looks like it might be an issue with how the comments are cached. The app might not be caching whether the user has already voted on a comment or not. I'll investigate further when I get a chance.

In other HN readers, I've found it really useful to be able to share either the article URL or the comments URL depending on context. The comments URL is a handy shared item because the HN comments page always links to the article URL. Thus, if the HN comments turn out to be more useful than the article, it's nice to share/bookmark those instead of the article itself.

It'd be nice if when you hit the bottom of a list, it automatically got the next page of results rather than requiring the user to hit the "More" button.

The app seems to crash on posts with a large number of comments. I can't tell if it's the high number of comments causing the crash, or a higher probability of the real cause of the crash in posts with many comments. The latest to crash is from a post with over 300 comments.

• Log in via the app
• Change password via Hacker News website
• Articles will load in HN, but upvoting etc won't work

Right now the app prevents me from upvoting anything since it incorrectly thinks it's already been upvoted on.

Note the timestamps: "Already voted on" is 45 minutes ago, while the last screenshot shows that I haven't voted on the comment from 1hr ago.

If you start playing a YouTube video and switch to comments while it is playing, the playback continues in the background. Audio from the video can be heard to prove this. If you then return to the page, a new instance of it is created and there is no way to stop the video without killing the app.

At least one of these characters causes "An unknown error occurred" that prevents logging in:

{".+?)&~

After I made my password alphanumeric, I was able to log in.

Logging in on the HN website was possible with and without these characters.

Only the root url is shown as a link, the GET portion is not linkified. This is an issue with the Regular expression used to linkify text. Using Linkify might solve this issue, but it also raises a couple of other ones. I'll do some googling for the best solution.

When clicking "more", the app does the whole "hey I'm loading" shindig and then just goes away. I think this because HN changed their first link to just <a href="news2"> and the parser is currently hunting for a leading slash. I fixed this up in #58, but I'll submit a separate pull request for just that one change to make merging easier.

Hello, i need help with the error. Follow the link.
http://www1.picturepush.com/photo/a/13170864/img/13170864.png
R?

Could an option be added to remove/filter articles read? Thanks

There should be something like "Couldn't fetch comments" or something similar displayed.

Thanks for the latest update to give us an option of different reading settings.

I have it set to use system browser, and it works fine when visiting a link from the list of articles. However going from list -> comments -> article defaults back to using the in app browser.

Could you please update that link to obey browser settings as well? Thanks.

An old comment shows up and then disappears once auto refreshed. Manual refreshing fails to retrieve comments as well.

Problematic comments:

https://news.ycombinator.com/item?id=6601870

On the main screen or comments screen, repeatedly tap the reload button and Android will report that the app has stopped. This does not effect article screens. Tested on version 1.9 from the F-Droid repository on a Nexus 4 running Android 4.2.2.

I dont use google play. Is there any way I can get a precompiled apk?

If I have a comment like this

And I follow it with some text here.

Then the line break between the careted text and the non-careted text will not show up. I have a feeling that this might be because Html.fromHtml is derping because of the leading caret. However, I'm not totally sure how to fix it.

This is probably related to the change I made to show ask-hn text. Weirdly it doesn't stay in "loading" state, which would indicate an error. Instead it just shows nothing. I've got midterms and a feature for the Github app that I'm working on right now, but this is next on my list after that.

In many user interfaces, the "view switching" buttons indicate the state the UI will be switched into. Currently this seems to be different in hn-android, where the button to switch into Comments is titled Article, and vice versa. Thanks

Is there a particular security reason for this over the convenience of easier transfer from old to new device ?

Android offers a nifty backup&restore functionality since 4.x with 'adb backup' and Koushik Dutta has made a great frontend app for it called Helium (https://play.google.com/store/apps/details?id=com.koushikdutta.backup).

In the whole list of 150 apps installed on my device the only 2 ones are :

• Google Authenticator (reasonable why the adb backup is disabled)
• HN Android.

This is really two parts.

1. The title isn't repeated on the comments page (which I would like).
2. (Ask|Poll) HN text bodies are missing.