mamaral / xkcd-open-source Goto Github PK

We need to add the badge info to the push payload, and clear the badge when the app enters the foreground/launches.

There are no new comics appearing in the app after comic #1607.

Hi,

I attached here a list of bugs or warnings that I found while analyzing this app with Infer (www.fbinfer.com) a static analyzer. I ran the tool on this app to test it and to have a case study to show in a talk I'll be giving next week about it. Do you think it's OK find for me to show the issues found in may talk, and show snippets of code?

https://www.dropbox.com/sh/5eku0yl6n27xwl4/AAArA0OzzVjkxwsSKNJ1v7d-a?dl=0

There are also bugs in file in the Pods, but the ones below are in the actual sources of the app:

Bugs

1. Source/Managers/Request Manager/RequestManager.m:74: warning: PARAMETER_NOT_NULL_CHECKED
   Parameter handler is not checked for null, there could be a null pointer dereference: pointer handler could be null and is dereferenced at line 74, column 9
   1. if (!token) {
   2. NSError *error = [self errorWithMessage:kRequestManagerNilTokenErrorMessage];
   3. *> * handler(error);
   4. return;
   5. }
2. Source/View Controllers/Comic/ComicViewController.h:27: warning: STRONG_DELEGATE_WARNING
   Property or ivar delegate declared strong at line 27, column 1. In general delegates should be declared weak or assign
   1. @interface ComicViewController : UIViewController
   3. *> *@Property (nonatomic) id delegate;
   5. @Property (nonatomic, strong) Comic *comic;
3. Source/View Controllers/Comic List/ComicListViewController.m:32: warning: REGISTERED_OBSERVER_BEING_DEALLOCATED
   Object self is registered in a notification center but not being removed before deallocation at line 32, column 1. Consider removing the object from the notification center before its deallocation.
   1. @EnD
   3. *> *@implementation ComicListViewController
4. Source/Managers/Data Manager/DataManager.m:22: warning: REGISTERED_OBSERVER_BEING_DEALLOCATED
   Object self is registered in a notification center but not being removed before deallocation at line 22, column 1. Consider removing the object from the notification center before its deallocation.
   1. @EnD
   3. *> *@implementation DataManager

Thanks a lot,
Dulma

The other XKCD app I have lets you easily tap to download a comic for offline viewing. This would be an awesome addition to this app.

It would be great to modally present the explainxkcd page in a safari web view.

The current web view has several glitches, and the SFSafariViewController class is designed to eliminate app designers from the burden of creating an in-app browser:

If your app lets users view websites from anywhere on the Internet, use the SFSafariViewController class. If your app customizes, interacts with, or controls the display of web content, use the WKWebView class.¹

However, it is only available in iOS 9+.

"Oooo, I need to send this one to . I'll send it with <iMessage, email, other share-sheet method>"

Oh :-(

I always find myself attempting to swipe left and right when viewing comics on my phone, before remembering that the forward/back buttons are in the toolbar. A swipe-to-change-comics feature could be useful.

Hi!

I reviewed the latest version of the app (2.5) asking to add support for @2x webcomics. Indeed, Randall has always provided an @2x version of the comic beginning with 1084 (see here). They're just the standard img URL with _2x appended before the extension. One could easily check that the comic is 1084 or later and also check the PNG actually exists (in case it's missing or it's a special comic).

Cheers!

Would be awesome to support a URL scheme to allow apps like Opener to open individual comics in the app.

The current version has black bars on the top and bottom (letterbox compatibility mode) and forces other apps into the same mode in split view. Could you rebuild the app (if need be without new features) to support the new devices?

Hey there,

Thanks for your work on such a terrific little project.

I would love to see the option to show only unread comics, this way you can make sure you literally have not missed a single XKDC comic created.

Thanks!

It would be nice if there were a way to pick a random comic but only among the cached ones for when you don't have an internet connection.

I might be able to work on this myself; could I have a hint as to which files are responsible for networking and random comic picking so I don't have to search through everything?

I like the app and I've been reading xkcd for a lot of years. Being new to the app, but a long time reader, it would be great if I could do a mark all as read. It would sure beat pressing the random button 1,894 times.

Particularly for some of the April fools comics, there's no way to mark them as read (it doesn't happen automatically because those are different from the normal comics) so if you use the unread only view a lot (I do) those ones never go away.

It would be great to have the comic zoom when double tapped. I have One handed use in mind.

Locking an issue like that is absurd. The issues with privacy on Apple software is as well documented as with Microsoft software. That is not relevant to the issue that I created, which you ignored the important part of. The important part of the issue was the tracking code itself, not with the tracking account.

The widget is not interactive at all. I was expecting it to open the comic in the app when I tap the widget. Especially since the widget does not display the entire image in Show More mode.

Current XKCD#: 2102
Device details:
iPhone XR
iOS 12.1.3

There is a cool easter egg to view all comics in 3D. If you go to https://3d.xkcd.com you can see it. I don’t know how hard that would be to add to the app, but it would be a cool thing to possibly have as a hidden setting only shown after reading 880 (the one that introduced the 3D thing).

When on view unread it doesn’t seem to have the same arrow/swipe navigation (or I’m doing it wrong)

I always find myself searching for the little triple dot in the top right hand corner. What if tapping the comic brought up the title text as well? This would be especially handy on larger screen devices on which it is sometimes tricky to reach the top right hand corner of the device.

Let's try to get to at least 50% code coverage ASAP.

It would be cool if you can preview comics using 3D touch on the home screen.

I am concerned that this software is tracking users without their consent, and without the option for users to disable this tracking. After reviewing the source of this application, I see that almost every event is tracked.

Within the last week or so, the app has stopped downloading new comics. I tried uninstalling and reinstalling the app, and now it won’t load any at all - it just gets itself into an infinite loop of displaying the “Oops! An error occurred while loading this content...” message. Please fix this - I loved this app!

At least one comic #1311 has a really long alt text that is too large for the screen. We need to handle this better.

Determine the most common languages users consume the app in and get translations for in-app strings.

Great app but all comics are always fully zoomed. As a result, the smallest of them look poorly on iPad's.

Requested in an app review.

In the other XKCD app I have, I can search a phrase or text from the comic content itself, not just the title and it will find it. That would be awesome for this app! I even have an idea for how to do it.

While I know that it did not work due to the interactive component, fixing the comic in question to show the result would be nice.

Some comics aren't just images, they might be interactive pages or GIFs or some other stuff that we need to handle accordingly. First we need to investigate what these comics are and how to handle them. We should also use this area to keep track of any we come across.

On one other app I believe when you double tapped or held it popped up the title which I thought was pretty convient! Great app!

The iPad Pro's screen is large enough that comics can be comfortably read from the main comic selection view (in fact, I often do this). It would be extra nice if I could tap the little comic number icons to bring up the title text for each comic (and also possibly mark that comic as read).

@mamaral
Hi！

I think inside the Cell to do clearance, this will happen asymmetric clearance, if within ComicListFlowLayout for horizontal or vertical gap will be more beautiful,

Like this picture：

Do an accessibility audit and ensure we're doing everything we can do be accessible.

On launch, the app crashes after ~1 second of showing the launch screen. Problem is fixed via reinstalling app.

Crash Report:
xkcd Open Source-2018-11-11-142707.ips.zip

Brand new install on iPhone X with iOS 11.4. A small comic thumbnail appears for a second, then goes away, then a dialog box shows up with: “Oops! Am error occurred while loading this content. Please check your connection and try again” I am on WiFi. Uninstalling and reinstalling haven’t helped

Notifications have stopped working again (yes, they are enabled in settings).

iPad Pro (12.9-inch) (3rd generation) – iOS 12.3

Can you add What if? option to this app too?
It would make this app perfect.

It seems there's an incompatibility with encodings here

There's been almost 500 events reported in Google Analytics with the following error:

The resource could not be loaded because the App Transport Security policy requires the use of a secure connection.

So... let's uh.... fix that...

Add ability to bookmark so you can quickly navigate to a specific comic - i.e. if you are reading them all in order and want to continue where you left off.

Imagining a bookmark icon on the comic screen itself, and a bookmark icon on the comic list next to the heart icon that when selected will scroll-to and open the last bookmarked comic... Only one bookmark would exist per app?

If you open and close a comic from the "liked comics" screen, the scroll resets to the top, which is frustrating.

Going forward or backward is currently bland. It'd be cool if we can page through the comics.

This is most-likely due to the shadow/layer behind the comic number label in ComicCell. Lets not do that anymore for version 1.1.

The encoding used for displaying the alt text does not match the encoding used by the server.
An example can be seen in comic 1814, where the notes on either end end the "é" are displayed incorrectly.

Title says it all. Haven't been getting updates for about a week now.