Code Monkey home page Code Monkey logo

Comments (6)

malte0811 avatar malte0811 commented on September 17, 2024

This seems to be caused by Chisel, no idea how though.
@tterrag1098 any suggestions? I feel like I am missing something stupid here. Blockstate JSON, Model JSON. IE has some blocks using practically the same JSON's, those seem to be fine...

from industrialwires.

tterrag1098 avatar tterrag1098 commented on September 17, 2024

Can't tell you much without an error log

from industrialwires.

malte0811 avatar malte0811 commented on September 17, 2024

There doesn't seem to be any error log, I looked for "industrialwires" and "motor" (one of the broken blocks) in the client fml log and didn't find anything except for some messages saying that the item models were being redirected to the block state json, which they should be. The textures don't show up as missing in the missing textures output when first entering the main menu.

from industrialwires.

tterrag1098 avatar tterrag1098 commented on September 17, 2024

The way your converter block uses extended states is strange. You shouldn't be modifying the base blockstate in that method. I don't even see the purpose of your getExtendedState code at all. I would try first getting rid of that to see if it solves the problem

from industrialwires.

malte0811 avatar malte0811 commented on September 17, 2024

That fixed it, thanks. I don't know why I put that stuff in getExtendedState, I probably wasn't paying too much attention to it when I did so. I will push a fix and publish a new release in a bit.
The reason why removing the getExtendedState method fixed it is not that I was modifying the non-extended block state in getExtendedBlockState since the same modification was done in getActualBlockState: It was the fact that I made getActualState return getExtendedState which calls the superclass method. Normally that method just returns the state parameter, but with Chisel it wraps the parameter in some Chisel specific extended block state. And since the block states used to map states to models don't equal (hashCode/equals) their wrapped states MC was unable to retrieve a model for that state.

from industrialwires.

tterrag1098 avatar tterrag1098 commented on September 17, 2024

Yeah, that was what I meant. Extended states are only meant for rendering and shouldn't ever be passed to normal game logic. Glad you solved it.

from industrialwires.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.