make-software / casper-event-standard Goto Github PK

View Code? Open in Web Editor NEW

6.0 6.0 7.0 39 KB

The smart contract level events for Casper Network.

Home Page: https://crates.io/crates/casper-event-standard

License: Apache License 2.0

Rust 95.13% Just 4.87%

blockchain blockchain-technology casper-network ces smart-contracts

casper-event-standard's People

Contributors

Stargazers

Watchers

Forkers

davidatwhiletrue akirapham cspr-rad alsrdn odradev deuszex

casper-event-standard's Issues

Cargo.lock is not stored in repository

Building this library is not reproducible, and fails due to nightly toolchain incompatibilities.

For years official Rust guides were recommending to not commit lock files for libraries (only for applications), however this changed year ago - see rust-lang/cargo#8728.

Now it is agreed that lock files should be always stored in VCS, but simply not published in libraries artifacts.

Add OSS pieces

Change error of validation.

Right now type validation throws Formatting when CLType::Any. Change it to something more meaningfull.

Typo: `lenght` -> `length`

I noticed 3 misspelled occurrences in the code:

casper-event-standard/casper-event-standard/src/contract.rs

Lines 30 to 37 in 24ef1df

    
           let lenght: u32 = storage::read(length_uref) 
        
               .unwrap_or_revert() 
        
               .unwrap_or_revert(); 
        
           let seed = event_dict_seed(); 
        
           let event_bytes = event.to_bytes().unwrap_or_revert(); 
        
           let event_bytes: Bytes = event_bytes.into(); 
        
           storage::dictionary_put(seed, &lenght.to_string(), event_bytes); 
        
           storage::write(length_uref, lenght + 1);

Make event validation during compilation.

Change default branch

The current default branch is outdated, which makes contributing hard. Consider changing it to the latest release or updating the dev branch.

make-software / casper-event-standard Goto Github PK

casper-event-standard's People

Contributors

Stargazers

Watchers

Forkers

casper-event-standard's Issues

Cargo.lock is not stored in repository

Add OSS pieces

Change error of validation.

Typo: `lenght` -> `length`

Make event validation during compilation.

Change default branch

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	let lenght: u32 = storage::read(length_uref)
	.unwrap_or_revert()
	.unwrap_or_revert();
	let seed = event_dict_seed();
	let event_bytes = event.to_bytes().unwrap_or_revert();
	let event_bytes: Bytes = event_bytes.into();
	storage::dictionary_put(seed, &lenght.to_string(), event_bytes);
	storage::write(length_uref, lenght + 1);