Addition of inner type which doesn't pass through shutdown() calls about rs-async-zip HOT 3 CLOSED

No worries at all. This was actually something I wanted to look into further anyway as I knew it was going to cause issues down the line but for my specific use cases so far (files & cursors), having the shutdown() call chain up wasn't causing any issues, so I just moved onto other things in all honesty.

Saw your post recently and was going to comment, but didn't in the end as you'd already found a workaround.

An additional function in async_compression like into_inner() but that doesn't discard state would be an ideal solution to this. :)
Though, your workaround would work pretty well as well here given there wouldn't be any legitimate uses of shutdown() stemming from the EntryStreamWriter.

Only made this issue myself as I only tend to work on this crate in bursts, so if anyone else wants to further this in the meantime, it'd be appreciated. I'll end up taking it anyway if not.

from rs-async-zip.

Hi @Majored, that was me! :)

Only reason why I didn't file this issue myself, is because one of the people who helped me identify this bug told me he was already working on a PR.

@Nemo157 author of async_compression, mentioned he's happy to provide the relevant API to solve this properly. Pinging him, in case.

from rs-async-zip.

I've gone ahead and added this inner type and your original code (without the customised DuplexStream) is now working correctly on my end.

I'll eventually get around to making a PR for async_compression with the API change needed for this (if no one else has), but I want to get familiar with the codebase before doing that given its heavy use of macros for code generation/abstraction.

Let me know if you still run into any issues with this.

from rs-async-zip.