Comments (8)
Okay, so I made a test that you can try. I want to see if this happens on other systems at all. Try with these jars:
minecraft-comes-alive-7.5.3+1.20-universal.jar
clutter-1.20-0.3.6.jar
spark-1.10.42-fabric.jar
wynntils-0.0.3-alpha.89-quilt.jar
This may just be an implementation bug (my fault), but I'm not exactly sure what it is.
@SylvKT I've noticed that on https://github.com/SylvKT/sylv-api/blob/e57f877ee73b8b2b4ef379eb1b81d3c07cb4cc12/src/task/retrieve_jar.rs#LL78C20-L78C20 it's using file.write() which isn't guaranteed to write the entire buffer (https://docs.rs/tokio/latest/tokio/io/trait.AsyncWriteExt.html#method.write), I think it needs to use write_all.
To verify you can log the response of write and the size of the buffer to see if they match.
Or you save the downloaded jars can you try opening them in a normal zip program.
But I'd recommend using something like https://stackoverflow.com/a/74283625 so it doesn't have to save everything in memory and write to a file, it'll just write bytes in chunks as they are downloaded.
from rs-async-zip.
Okay, so I made a test that you can try. I want to see if this happens on other systems at all. Try with these jars:
minecraft-comes-alive-7.5.3+1.20-universal.jar
clutter-1.20-0.3.6.jar
spark-1.10.42-fabric.jar
wynntils-0.0.3-alpha.89-quilt.jar
This may just be an implementation bug (my fault), but I'm not exactly sure what it is.@SylvKT I've noticed that on https://github.com/SylvKT/sylv-api/blob/e57f877ee73b8b2b4ef379eb1b81d3c07cb4cc12/src/task/retrieve_jar.rs#LL78C20-L78C20 it's using file.write() which isn't guaranteed to write the entire buffer (https://docs.rs/tokio/latest/tokio/io/trait.AsyncWriteExt.html#method.write), I think it needs to use write_all.
To verify you can log the response of write and the size of the buffer to see if they match. Or you save the downloaded jars can you try opening them in a normal zip program.
But I'd recommend using something like https://stackoverflow.com/a/74283625 so it doesn't have to save everything in memory and write to a file, it'll just write bytes in chunks as they are downloaded.
Using write_all
seems to have fixed the issue. Thank you! Also, sorry for opening an invalid issue.
from rs-async-zip.
I'm not personally getting an UnableToLocateEOCDR error with 0.0.15 on macOS (https://imgur.com/l5jGjhE).
Are you sure the file you're downloading is getting properly saved?
from rs-async-zip.
It's possible that it's trying to read the file before it's saved. I'll have to do more testing.
However, it's only those specific files.
from rs-async-zip.
After some tinkering, I've managed to somehow fix it. I don't know why this works, but it does. This must've been user error. I'm still going to investigate what I did differently.
https://github.com/SylvKT/sylv-api/blob/29c7790e36f035d5d5055062fd662aef62f3a543/src/task/retrieve_jar.rs#L207
from rs-async-zip.
So, it seems that the error still persists, but it's somewhat random. I've made it wait for one second now, but it doesn't seem to help.
from rs-async-zip.
This may be related to #70
from rs-async-zip.
Okay, so I made a test that you can try. I want to see if this happens on other systems at all. Try with these jars:
minecraft-comes-alive-7.5.3+1.20-universal.jar
clutter-1.20-0.3.6.jar
spark-1.10.42-fabric.jar
wynntils-0.0.3-alpha.89-quilt.jar
This may just be an implementation bug (my fault), but I'm not exactly sure what it is.
from rs-async-zip.
Related Issues (20)
- How to construct ZipDateTime without chrono dependency? HOT 3
- `tokio::io::AsyncRead`(`Ext`) doesn't seem to be implemented for `async_zip::tokio::read::ZipEntryReader` HOT 2
- OwnedEntryStreamWriter HOT 2
- deflate64 support
- Support to read Info-ZIP Unicode Path Extra Field HOT 1
- Incorrect Zip64 Header Implementation HOT 8
- Tokio file doesn't satisfy `tokio::fs::File: futures_lite::AsyncWrite` HOT 1
- Incorrect parsing of zip64 extended information field HOT 1
- New Release? HOT 3
- Offset and size of entry in archive HOT 1
- Parallel Zip Stream support HOT 2
- Async ZIP Streaming?... HOT 13
- Test failures on 32-bit arches HOT 2
- data descriptor not supported error HOT 11
- Broken pipe occurs. HOT 4
- Streaming - Write file in chunks HOT 2
- Option to compress externally and just store input compressed byte stream.
- a computed CRC32 value did not match the expected value - when CRC is in data_descriptor HOT 2
- Can't properly use the stream method
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rs-async-zip.