make filename an owned type about rs-async-zip HOT 3 CLOSED

There's no actual explicit 'static lifetime, but likely an implicit one due to being placed on the heap (Arc/Box). Heck, even my own example for the read::fs module puts it on the heap.

So given that, and the fact that the whole point of read::fs is to be parallel, making it an owned string is really the only option I can see as well. I could use a Cow, but to make that work, we'd have to make the caller pass a pre-constructed Cow and decide whether it be borrowed or owned. That doesn't feel like a good API design to me.

I'll get this done when I next go to work on this crate. 👍

Edit: Though, I guess I could just have two different constructors that handle the Cow construction as well for you. That seems quite a good idea actually.

from rs-async-zip.

Thanks. For what it’s worth it’s less the lifetime constraints of this crate than it is the async ecosystem.

Following the example code, functions like tokio::spawn require static lifetimes

from rs-async-zip.

Actually, coming back to this, I'm going to make it an owned string as you suggest.
No point in adding the complexity with Cow & two different constructors for the sake of a single allocation.

from rs-async-zip.